issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 589632313 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • In-place addition of arrays with the same coords but in a different order · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
606135881 https://github.com/pydata/xarray/issues/3910#issuecomment-606135881 https://api.github.com/repos/pydata/xarray/issues/3910 MDEyOklzc3VlQ29tbWVudDYwNjEzNTg4MQ== max-sixty 5635139 2020-03-30T17:29:36Z 2020-03-30T17:29:36Z MEMBER

Yes exactly! And I think in-place might be surprising if it changed the indexes of the left item; i.e. if you got this result from A += B:

```python

In [17]: ...: ...: import numpy as np ...: import xarray as xr ...: ...: n = 5 ...: ...: d1 = np.arange(1, n+1) ...: np.random.shuffle(d1) ...: A = xr.DataArray(np.ones(n), coords=[('dim', d1)]) ...: ...: d2 = np.arange(n) ...: np.random.shuffle(d2) ...: B = xr.DataArray(np.ones(n), coords=[('dim', d2)]) ...: ...: A + B Out[17]: <xarray.DataArray (dim: 4)> array([2., 2., 2., 2.]) Coordinates: * dim (dim) int64 3 2 1 4 ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   In-place addition of arrays with the same coords but in a different order 589632313
606070776 https://github.com/pydata/xarray/issues/3910#issuecomment-606070776 https://api.github.com/repos/pydata/xarray/issues/3910 MDEyOklzc3VlQ29tbWVudDYwNjA3MDc3Ng== max-sixty 5635139 2020-03-30T15:30:26Z 2020-03-30T15:30:26Z MEMBER

Thanks in advance @mancellin

Your comment is almost exactly right. It's that they might not align fully, rather than the shape; i.e. if your example had range(1,5) rather than range(0,4), then the array would need to be converted to float to add a NaN. Does that make sense?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   In-place addition of arrays with the same coords but in a different order 589632313
605676519 https://github.com/pydata/xarray/issues/3910#issuecomment-605676519 https://api.github.com/repos/pydata/xarray/issues/3910 MDEyOklzc3VlQ29tbWVudDYwNTY3NjUxOQ== dcherian 2448579 2020-03-29T18:08:22Z 2020-03-29T18:08:22Z MEMBER

@mancellin Are you up for sending in a PR with a better error message?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   In-place addition of arrays with the same coords but in a different order 589632313
605501583 https://github.com/pydata/xarray/issues/3910#issuecomment-605501583 https://api.github.com/repos/pydata/xarray/issues/3910 MDEyOklzc3VlQ29tbWVudDYwNTUwMTU4Mw== max-sixty 5635139 2020-03-28T18:38:01Z 2020-03-28T18:41:52Z MEMBER

Yes, this is unfortunate. The reasoning: https://github.com/pydata/xarray/blob/732b6cd6248ce715da74f3cd7a0e211eaa1d0aa2/xarray/core/dataarray.py#L2618-L2621

It may be possible to at align in some cases (e.g. if the indexes are bijective / one-to-one, or the values are already floats). Or a better error message; even one containing that comment would be better.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   In-place addition of arrays with the same coords but in a different order 589632313

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);