issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 588112617 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • Add public API for Dataset._copy_listed · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
675125293 https://github.com/pydata/xarray/issues/3894#issuecomment-675125293 https://api.github.com/repos/pydata/xarray/issues/3894 MDEyOklzc3VlQ29tbWVudDY3NTEyNTI5Mw== max-sixty 5635139 2020-08-17T21:29:22Z 2020-08-17T21:29:22Z MEMBER

A level down, re the name — I thought .vars might be decent — but potentially it's too similar to .variables — which is a mapping to the actual variables (and can't take multiple selections)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add public API for Dataset._copy_listed 588112617
675124770 https://github.com/pydata/xarray/issues/3894#issuecomment-675124770 https://api.github.com/repos/pydata/xarray/issues/3894 MDEyOklzc3VlQ29tbWVudDY3NTEyNDc3MA== max-sixty 5635139 2020-08-17T21:27:59Z 2020-08-17T21:27:59Z MEMBER

I do think having a Dataset behave similarly to a dict / Mapping is generally good, and allows new users to bring existing understandings around those data structures to the xarray data model.

I recognize that a hashable iterable (e.g. ('a', 'b', 'c') is an annoying corner case, though. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add public API for Dataset._copy_listed 588112617
604506561 https://github.com/pydata/xarray/issues/3894#issuecomment-604506561 https://api.github.com/repos/pydata/xarray/issues/3894 MDEyOklzc3VlQ29tbWVudDYwNDUwNjU2MQ== max-sixty 5635139 2020-03-26T15:46:05Z 2020-03-26T15:46:05Z MEMBER

Would that be different from ensuring the input is a list?

Moreover, because Dataset__getitem__ is type unstable,

I very much empathize with the pain from methods being type unstable; indeed I think that's one of the biggest benefits of xarray over pandas. Here, it's stable over the same typed inputs. i.e. if supplied with a list, it returns with a dataset, otherwise it returns a DataArray. (or am I missing something?)

it makes it hard to detect this kind of error using mypy

Is there a way in mypy we could use something like overload to specify the above contract here, as an alternative to another method?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add public API for Dataset._copy_listed 588112617

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);