issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 573577844 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Opening from zarr.ZipStore fails to read (store???) unicode characters · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
603977609 https://github.com/pydata/xarray/issues/3815#issuecomment-603977609 https://api.github.com/repos/pydata/xarray/issues/3815 MDEyOklzc3VlQ29tbWVudDYwMzk3NzYwOQ== max-sixty 5635139 2020-03-25T17:28:35Z 2020-03-25T17:28:35Z MEMBER

Thanks for the alternative repro. And I'm fairly confident this is a zarr issue; if the format can't handle a zero-dimensioned coord, it should raise a specific error rather than it being a bad ZipFile

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Opening from zarr.ZipStore fails to read (store???) unicode characters 573577844
603974527 https://github.com/pydata/xarray/issues/3815#issuecomment-603974527 https://api.github.com/repos/pydata/xarray/issues/3815 MDEyOklzc3VlQ29tbWVudDYwMzk3NDUyNw== max-sixty 5635139 2020-03-25T17:22:57Z 2020-03-25T17:22:57Z MEMBER

I've avoided attrs since they often get "lost" in computation, and don't get dragged along as rigorously as coordinates.

Yeah, we're gradually fixing this. You can set a config to keep attrs by default, or pass keep_attrs=True in most methods. We might still be missing a couple of methods; would appreciate a bug report for any of those.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Opening from zarr.ZipStore fails to read (store???) unicode characters 573577844
603650213 https://github.com/pydata/xarray/issues/3815#issuecomment-603650213 https://api.github.com/repos/pydata/xarray/issues/3815 MDEyOklzc3VlQ29tbWVudDYwMzY1MDIxMw== max-sixty 5635139 2020-03-25T05:36:00Z 2020-03-25T05:36:00Z MEMBER

I had a quick debug but didn't completely resolve it. It works fine if you add it as an attribute; do you mean to be adding a single string as a data variable?

```python

In [8]: import xarray as xr ...: import zarr ...: x = xr.Dataset() ...: x.attrs['hello'] = 'world' # changed ...: x ...: with zarr.ZipStore('test_store.zip', mode='w') as store: ...: x.to_zarr(store) ...: with zarr.ZipStore('test_store.zip', mode='r') as store: ...: x_read = xr.open_zarr(store).compute() ...: ```

Debugging is non-trivial because the ZipFile is closed by the time I could run %debug. It's not impossible but would take more than a quick look in a repl. That said, I do think this looks likely to be a zarr issue given it depends on the storage format that zarr is using. It's possible xarray is calling it incorrectly but I'd think it's less likely.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Opening from zarr.ZipStore fails to read (store???) unicode characters 573577844
603646754 https://github.com/pydata/xarray/issues/3815#issuecomment-603646754 https://api.github.com/repos/pydata/xarray/issues/3815 MDEyOklzc3VlQ29tbWVudDYwMzY0Njc1NA== max-sixty 5635139 2020-03-25T05:21:53Z 2020-03-25T05:21:53Z MEMBER

@hmaarrfk my apologies, I misread your issue and it was always reproducible. I had thought it was referencing a file test_store.zip when actually it was writing it, mea culpa.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Opening from zarr.ZipStore fails to read (store???) unicode characters 573577844
603569789 https://github.com/pydata/xarray/issues/3815#issuecomment-603569789 https://api.github.com/repos/pydata/xarray/issues/3815 MDEyOklzc3VlQ29tbWVudDYwMzU2OTc4OQ== max-sixty 5635139 2020-03-25T00:13:16Z 2020-03-25T00:13:16Z MEMBER

You did supply the traceback! But it's not reproducible. And consistent with https://github.com/pydata/xarray/issues/3831#issuecomment-595403356, it's difficult to attribute the break on examples like these.

You could try debugging into the return array[key.tuple] call, which is the last one in xarray, and identifying whether xarray is making a bad call or zarr is incorrectly failing?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Opening from zarr.ZipStore fails to read (store???) unicode characters 573577844
603295542 https://github.com/pydata/xarray/issues/3815#issuecomment-603295542 https://api.github.com/repos/pydata/xarray/issues/3815 MDEyOklzc3VlQ29tbWVudDYwMzI5NTU0Mg== max-sixty 5635139 2020-03-24T15:10:21Z 2020-03-24T15:10:21Z MEMBER

Do you have a reproducible example? Otherwise I'm not sure how to help resolve...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Opening from zarr.ZipStore fails to read (store???) unicode characters 573577844
602271821 https://github.com/pydata/xarray/issues/3815#issuecomment-602271821 https://api.github.com/repos/pydata/xarray/issues/3815 MDEyOklzc3VlQ29tbWVudDYwMjI3MTgyMQ== max-sixty 5635139 2020-03-22T20:57:02Z 2020-03-22T20:57:02Z MEMBER

Hi @hmaarrfk , I don't know this area of code well but attempting to ensure that we resolve the question.

Should this be an xarray or a zarr issue? Is there something you think xarray is doing incorrectly here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Opening from zarr.ZipStore fails to read (store???) unicode characters 573577844

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);