issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 559864146 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • isort pre-commit hook does not skip text files · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
582654456 https://github.com/pydata/xarray/issues/3750#issuecomment-582654456 https://api.github.com/repos/pydata/xarray/issues/3750 MDEyOklzc3VlQ29tbWVudDU4MjY1NDQ1Ng== keewis 14808389 2020-02-05T23:01:09Z 2020-02-05T23:01:09Z MEMBER

actually, isort does support filtering using --filter-files -sg '*.rst' which would blacklist rst files. Since we don't have just rst files, I think that whitelisting is a better approach. Maybe we should use files: .\.py$?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   isort pre-commit hook does not skip text files 559864146
582651268 https://github.com/pydata/xarray/issues/3750#issuecomment-582651268 https://api.github.com/repos/pydata/xarray/issues/3750 MDEyOklzc3VlQ29tbWVudDU4MjY1MTI2OA== mathause 10194086 2020-02-05T22:50:54Z 2020-02-05T22:50:54Z MEMBER

You can tell isort to skip files in the setup.cfg but this seems to be ignored when doing isort file (which is what happens in the pre-commit hook) - see https://github.com/pre-commit/mirrors-isort/issues/9#issuecomment-511434587

So I think adapting .pre-commit-config.yaml is the way to go at the moment. (Maybe adapt setup.cfg anyway to ensure it does not happen when isort is called with isort -rc .).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   isort pre-commit hook does not skip text files 559864146
582127727 https://github.com/pydata/xarray/issues/3750#issuecomment-582127727 https://api.github.com/repos/pydata/xarray/issues/3750 MDEyOklzc3VlQ29tbWVudDU4MjEyNzcyNw== keewis 14808389 2020-02-04T21:38:41Z 2020-02-04T21:38:41Z MEMBER

pre-commit allows filtering the files passed to a hook using regular expressions: diff - repo: https://github.com/timothycrosley/isort rev: 4.3.21-2 hooks: - id: isort + files: ".+[.]py" # https://github.com/python/black#version-control-integration - repo: https://github.com/python/black Not sure if this regex is the one we should use, but it does seem to work.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   isort pre-commit hook does not skip text files 559864146

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);