issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 532878771 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • dcherian · 2 ✖

issue 1

  • xr.Dataset.map drops attrs of DataArray · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
561819897 https://github.com/pydata/xarray/issues/3595#issuecomment-561819897 https://api.github.com/repos/pydata/xarray/issues/3595 MDEyOklzc3VlQ29tbWVudDU2MTgxOTg5Nw== dcherian 2448579 2019-12-04T20:13:57Z 2019-12-04T20:13:57Z MEMBER

I think that it's sensible that keep_attrs controls whether individual variable attrs are kept after mapping a function on each variable.

This is a behaviour change though. I'm not sure how to deal with that.

cc @max-sixty 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.Dataset.map drops attrs of DataArray 532878771
561810709 https://github.com/pydata/xarray/issues/3595#issuecomment-561810709 https://api.github.com/repos/pydata/xarray/issues/3595 MDEyOklzc3VlQ29tbWVudDU2MTgxMDcwOQ== dcherian 2448579 2019-12-04T19:49:00Z 2019-12-04T19:52:10Z MEMBER

Looking at the code, keep_attrs controls whether the dataset attrs are kept, not the invidual variable attrs.

https://github.com/pydata/xarray/blob/577d3a75ea8bb25b99f9d31af8da14210cddff78/xarray/core/dataset.py#L4233-L4240

This may be fixable by threading keep_attrs down through maybe_wrap_array and then ultimately to Variable.__array_wrap__ when you can choose to keep attrs if keep_attrs is True.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.Dataset.map drops attrs of DataArray 532878771

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);