issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 532373563 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Silence sphinx warnings: Round 2 · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
562621269 https://github.com/pydata/xarray/pull/3592#issuecomment-562621269 https://api.github.com/repos/pydata/xarray/issues/3592 MDEyOklzc3VlQ29tbWVudDU2MjYyMTI2OQ== dcherian 2448579 2019-12-06T15:37:48Z 2019-12-06T15:37:48Z MEMBER

Thanks @keewis 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings: Round 2 532373563
562542618 https://github.com/pydata/xarray/pull/3592#issuecomment-562542618 https://api.github.com/repos/pydata/xarray/issues/3592 MDEyOklzc3VlQ29tbWVudDU2MjU0MjYxOA== max-sixty 5635139 2019-12-06T11:48:35Z 2019-12-06T11:48:35Z MEMBER

Looks great!! Really good that we can enforce the warnings from here

(I'm on vacation so forgive the lack of engagement)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings: Round 2 532373563
562263980 https://github.com/pydata/xarray/pull/3592#issuecomment-562263980 https://api.github.com/repos/pydata/xarray/issues/3592 MDEyOklzc3VlQ29tbWVudDU2MjI2Mzk4MA== keewis 14808389 2019-12-05T18:52:25Z 2019-12-05T19:26:44Z MEMBER

now CI should fail on new warnings (no nit-picks, so no complaints about broken links).

I will open a new PR later to silence the nitpicky warnings.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings: Round 2 532373563
562260172 https://github.com/pydata/xarray/pull/3592#issuecomment-562260172 https://api.github.com/repos/pydata/xarray/issues/3592 MDEyOklzc3VlQ29tbWVudDU2MjI2MDE3Mg== keewis 14808389 2019-12-05T18:42:31Z 2019-12-05T18:42:31Z MEMBER

I'll update the CI, then.

We could also have CI run doctest so we know which examples need updates, but we'd first need fix all outdated examples.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings: Round 2 532373563
562258825 https://github.com/pydata/xarray/pull/3592#issuecomment-562258825 https://api.github.com/repos/pydata/xarray/issues/3592 MDEyOklzc3VlQ29tbWVudDU2MjI1ODgyNQ== dcherian 2448579 2019-12-05T18:38:57Z 2019-12-05T18:38:57Z MEMBER

do we agree on dropping -n and adding -W --keep-going to the CI?

I think this is OK. If it gets too annoying, we can revert

I fixed this by removing the whole section

I think this is OK too. The attributes seem to get added to the html documentation automatically. The list you removed is formatted kind of badly at the beginning of the docstring. see the end of https://xarray.pydata.org/en/stable/generated/xarray.DataArray.html

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings: Round 2 532373563
562254505 https://github.com/pydata/xarray/pull/3592#issuecomment-562254505 https://api.github.com/repos/pydata/xarray/issues/3592 MDEyOklzc3VlQ29tbWVudDU2MjI1NDUwNQ== keewis 14808389 2019-12-05T18:27:55Z 2019-12-05T18:27:55Z MEMBER

do we agree on dropping -n and adding -W --keep-going to the CI? If so, I think I can do that in this PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings: Round 2 532373563
561461567 https://github.com/pydata/xarray/pull/3592#issuecomment-561461567 https://api.github.com/repos/pydata/xarray/issues/3592 MDEyOklzc3VlQ29tbWVudDU2MTQ2MTU2Nw== max-sixty 5635139 2019-12-04T03:35:06Z 2019-12-04T03:35:06Z MEMBER

Great!! Will be good to get CI up & running. Should we add that as part of this PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings: Round 2 532373563

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);