issue_comments

Table actions

13 rows where author_association = "MEMBER" and issue = 525972395 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Fix documentation · 13 ✖

author_association 1

  • MEMBER · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
557310518 https://github.com/pydata/xarray/pull/3554#issuecomment-557310518 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NzMxMDUxOA== keewis 14808389 2019-11-21T22:58:48Z 2019-11-21T22:58:48Z MEMBER

I removed the drop related changes, so we can merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
557200389 https://github.com/pydata/xarray/pull/3554#issuecomment-557200389 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NzIwMDM4OQ== keewis 14808389 2019-11-21T17:54:51Z 2019-11-21T17:55:06Z MEMBER

@max-sixty, I'm probably too occupied with #3557 to do this anytime soon, so go ahead if you want to (I'll remove the drop related changes).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556897541 https://github.com/pydata/xarray/pull/3554#issuecomment-556897541 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1Njg5NzU0MQ== max-sixty 5635139 2019-11-21T03:12:28Z 2019-11-21T03:12:28Z MEMBER

I'd like to have documentation available for anything in the public API, so that it can be a useful reference for both previously existing and new code. I think for deprecated functionality it makes the most sense to keep the docs, but warn prominently that it should not be used in new code (e.g. https://unidata.github.io/MetPy/dev/api/generated/metpy.calc.html#deprecated)?

I think this is a pretty good balance, i.e. a section with Deprecated / Pending Deprecation. If we can do that as part of this then great; otherwise I'm happy to have a go

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556545783 https://github.com/pydata/xarray/pull/3554#issuecomment-556545783 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NjU0NTc4Mw== keewis 14808389 2019-11-20T23:26:12Z 2019-11-20T23:26:12Z MEMBER

I do, but the builds currently choke on conda taking too much memory. Let's discuss that in #3557.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556539909 https://github.com/pydata/xarray/pull/3554#issuecomment-556539909 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NjUzOTkwOQ== dcherian 2448579 2019-11-20T23:20:16Z 2019-11-20T23:20:16Z MEMBER

@keewis Yes please! We might have to iterate on RTD. Do you have an RTD build set up already? If not, see https://github.com/pydata/xarray/issues/3369

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556530367 https://github.com/pydata/xarray/pull/3554#issuecomment-556530367 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NjUzMDM2Nw== keewis 14808389 2019-11-20T23:11:02Z 2019-11-20T23:11:02Z MEMBER

@dcherian: should I prepare a merge PR so we can make progress on that?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556466460 https://github.com/pydata/xarray/pull/3554#issuecomment-556466460 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NjQ2NjQ2MA== dcherian 2448579 2019-11-20T22:10:13Z 2019-11-20T22:10:13Z MEMBER

Is the problem there still that readthedocs fails but CI works, isn't it?

:+1:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556458230 https://github.com/pydata/xarray/pull/3554#issuecomment-556458230 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NjQ1ODIzMA== keewis 14808389 2019-11-20T22:02:41Z 2019-11-20T22:02:41Z MEMBER

Is the problem there still that readthedocs fails but CI works, isn't it?

@max-sixty, I think it should be fine as long as the deprecation is visible enough, but we could also add it to api-hidden.rst which would make the documentation page generate without adding it to api.rst

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556449103 https://github.com/pydata/xarray/pull/3554#issuecomment-556449103 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NjQ0OTEwMw== dcherian 2448579 2019-11-20T21:54:22Z 2019-11-20T21:54:30Z MEMBER

Here's the error rasterio.errors.RasterioIOError: '/vsicurl/https://github.com/mapbox/rasterio/raw/master/tests/data/RGB.byte.tif' does not exist in the file system, and is not recognized as a supported dataset name.

That URL does work. The /vsicurl/ is screwing it up?

I think our efforts may be better spent getting the scipy19-docs branch to work because that migrates the gallery .py scripts to notebooks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556331512 https://github.com/pydata/xarray/pull/3554#issuecomment-556331512 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NjMzMTUxMg== max-sixty 5635139 2019-11-20T20:09:56Z 2019-11-20T20:09:56Z MEMBER

the docs fail because it cannot find a rasterio / tif file.

Hmmm, I haven't seen that before. Do you know whether it fails on master? (I can check too)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556322791 https://github.com/pydata/xarray/pull/3554#issuecomment-556322791 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NjMyMjc5MQ== max-sixty 5635139 2019-11-20T20:02:37Z 2019-11-20T20:02:37Z MEMBER

My thought behind removing drop was to only list methods that we recommend people use. We're keeping drop for back-compat reasons, but I wouldn't recommend anyone who is creating new code use it.

But maybe that's too aggressive. Any thoughts anyone?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556279116 https://github.com/pydata/xarray/pull/3554#issuecomment-556279116 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NjI3OTExNg== keewis 14808389 2019-11-20T19:24:50Z 2019-11-20T19:24:50Z MEMBER

@max-sixty, what do you think about re-adding the parameter / returns sections of drop?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395
556226568 https://github.com/pydata/xarray/pull/3554#issuecomment-556226568 https://api.github.com/repos/pydata/xarray/issues/3554 MDEyOklzc3VlQ29tbWVudDU1NjIyNjU2OA== keewis 14808389 2019-11-20T18:40:22Z 2019-11-20T18:40:22Z MEMBER

the docs fail because it cannot find a rasterio / tif file. Does anyone know if that is a random / network error or if something broke?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix documentation 525972395

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);