issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 525903846 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • keewis · 4 ✖

issue 1

  • Dataset.drop() no longer works with a set as an argument · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
556319412 https://github.com/pydata/xarray/issues/3552#issuecomment-556319412 https://api.github.com/repos/pydata/xarray/issues/3552 MDEyOklzc3VlQ29tbWVudDU1NjMxOTQxMg== keewis 14808389 2019-11-20T19:59:48Z 2019-11-20T19:59:48Z MEMBER

the reason for set raising an error is that in drop is_list_like(labels) or is_scalar(labels) is used instead of isinstance(labels, str) or not isinstance(labels, Iterable). Since is_list_like explicitly checks for tuple and list, passing set obviously won't call the right method.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.drop() no longer works with a set as an argument 525903846
556105579 https://github.com/pydata/xarray/issues/3552#issuecomment-556105579 https://api.github.com/repos/pydata/xarray/issues/3552 MDEyOklzc3VlQ29tbWVudDU1NjEwNTU3OQ== keewis 14808389 2019-11-20T17:01:06Z 2019-11-20T17:03:20Z MEMBER

explicitly selecting should work like this: python ds = xr.Dataset( {"a": ("b", [0, 1, 2]), "c": ("b", [-1, 2, 4]), "d": ("b", [5, 1, 3])}, coords={"b": list("abc")}, ) variables = ["a", "d"] ds[variables] I think Dataset.__getitem__ allows any kind of sequence here (e.g. sets)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.drop() no longer works with a set as an argument 525903846
556094944 https://github.com/pydata/xarray/issues/3552#issuecomment-556094944 https://api.github.com/repos/pydata/xarray/issues/3552 MDEyOklzc3VlQ29tbWVudDU1NjA5NDk0NA== keewis 14808389 2019-11-20T16:49:05Z 2019-11-20T16:49:05Z MEMBER

so I guess we need to figure out why sets don't work anymore?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.drop() no longer works with a set as an argument 525903846
556094690 https://github.com/pydata/xarray/issues/3552#issuecomment-556094690 https://api.github.com/repos/pydata/xarray/issues/3552 MDEyOklzc3VlQ29tbWVudDU1NjA5NDY5MA== keewis 14808389 2019-11-20T16:48:33Z 2019-11-20T16:48:33Z MEMBER

I think drop was deprecated in favor of drop_sel and drop_vars (#3475). Using v0.14.1, this works: python ds = xr.Dataset({"a": ("b", [0, 1, 2]), "c": [-1, 2, 4]}, coords={"b": list("abc")}) ds.drop_vars({"a", "b"}) ds.drop_vars(["a", "b"]) ds.drop(["a", "b"])

Additionally, I think we have a documentation bug: I can't reach the documentation on drop.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.drop() no longer works with a set as an argument 525903846

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);