issue_comments

Table actions

7 rows where author_association = "MEMBER", issue = 521887948 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • dcherian · 7 ✖

issue 1

  • Silence sphinx warnings · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
555560903 https://github.com/pydata/xarray/pull/3516#issuecomment-555560903 https://api.github.com/repos/pydata/xarray/issues/3516 MDEyOklzc3VlQ29tbWVudDU1NTU2MDkwMw== dcherian 2448579 2019-11-19T15:31:33Z 2019-11-19T15:31:33Z MEMBER

I'm going to merge so we can get the docstring improvements out. Let's have a follow-up PR to fix the remaining warnings.

Thanks for the great work @keewis 🍻 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 521887948
555289057 https://github.com/pydata/xarray/pull/3516#issuecomment-555289057 https://api.github.com/repos/pydata/xarray/issues/3516 MDEyOklzc3VlQ29tbWVudDU1NTI4OTA1Nw== dcherian 2448579 2019-11-19T01:28:14Z 2019-11-19T01:28:14Z MEMBER

:man_shrugging: I think it's fine to merge right now. This is great work!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 521887948
555106174 https://github.com/pydata/xarray/pull/3516#issuecomment-555106174 https://api.github.com/repos/pydata/xarray/issues/3516 MDEyOklzc3VlQ29tbWVudDU1NTEwNjE3NA== dcherian 2448579 2019-11-18T16:53:15Z 2019-11-18T16:53:15Z MEMBER

Ok sounds good then

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 521887948
555087906 https://github.com/pydata/xarray/pull/3516#issuecomment-555087906 https://api.github.com/repos/pydata/xarray/issues/3516 MDEyOklzc3VlQ29tbWVudDU1NTA4NzkwNg== dcherian 2448579 2019-11-18T16:14:22Z 2019-11-18T16:14:22Z MEMBER

Will it still fail of there are errors?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 521887948
555076193 https://github.com/pydata/xarray/pull/3516#issuecomment-555076193 https://api.github.com/repos/pydata/xarray/issues/3516 MDEyOklzc3VlQ29tbWVudDU1NTA3NjE5Mw== dcherian 2448579 2019-11-18T15:50:10Z 2019-11-18T15:50:10Z MEMBER

I think so. Though would a decorator be cleaner? I'm pretty sure dask uses a decorator when they wrap numpy functions

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 521887948
554812963 https://github.com/pydata/xarray/pull/3516#issuecomment-554812963 https://api.github.com/repos/pydata/xarray/issues/3516 MDEyOklzc3VlQ29tbWVudDU1NDgxMjk2Mw== dcherian 2448579 2019-11-18T01:24:13Z 2019-11-18T01:24:13Z MEMBER

I think interpolating values with interp never had an existing label,

Lets do :ref:interp or whatever works for references to interpolation.rst

copies vs views is still there but with underscores instead of spaces and faq.other_projects got moved/renamed to related-projects

Let's change these appropriately.

the entry for tutorial actually looks fine, I'd simply put it in double-backticks.

:+1:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 521887948
554806634 https://github.com/pydata/xarray/pull/3516#issuecomment-554806634 https://api.github.com/repos/pydata/xarray/issues/3516 MDEyOklzc3VlQ29tbWVudDU1NDgwNjYzNA== dcherian 2448579 2019-11-18T00:34:41Z 2019-11-18T00:34:41Z MEMBER

How would you handle links to h5netcdf and cftime? Convert them to double-backtick quoted? I don't think either of them has working intersphinx entries?

Sounds good!

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 521887948

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);