issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 521754870 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 2 ✖

issue 1

  • Should we cache some small properties? · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
553573320 https://github.com/pydata/xarray/issues/3514#issuecomment-553573320 https://api.github.com/repos/pydata/xarray/issues/3514 MDEyOklzc3VlQ29tbWVudDU1MzU3MzMyMA== max-sixty 5635139 2019-11-13T19:52:18Z 2019-11-13T19:52:18Z MEMBER

By reading the implementation of cachedproperty, it needs a __dict__. It should be straightforward to write a variant that uses slots though.

Is there a way of doing that which doesn't nullify the benefits of slots? i.e. if we add a _cache_dict to the class, is that the same overhead as having a __dict__?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should we cache some small properties? 521754870
553093801 https://github.com/pydata/xarray/issues/3514#issuecomment-553093801 https://api.github.com/repos/pydata/xarray/issues/3514 MDEyOklzc3VlQ29tbWVudDU1MzA5MzgwMQ== max-sixty 5635139 2019-11-12T20:11:22Z 2019-11-12T20:11:35Z MEMBER

Great, I didn't know about that, thanks

It does remind me, though, that I'm not sure it's possible given we're using __slots__, at least without adding an entry to __slots__... https://github.com/python/cpython/blob/d360346640e19231032b072216195484fa2450b4/Lib/functools.py#L954-L958

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should we cache some small properties? 521754870

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);