issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 520306672 and user = 13301940 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • andersy005 · 3 ✖

issue 1

  • Harmonize `FillValue` and `missing_value` during encoding and decoding steps · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
553008854 https://github.com/pydata/xarray/pull/3502#issuecomment-553008854 https://api.github.com/repos/pydata/xarray/issues/3502 MDEyOklzc3VlQ29tbWVudDU1MzAwODg1NA== andersy005 13301940 2019-11-12T17:47:11Z 2019-11-12T17:47:11Z MEMBER

@dcherian & @shoyer, thank you both for your help!

In which section(bug fixes? enhancements?) in whats-new.rst should I document these changes?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Harmonize `FillValue` and `missing_value` during encoding and decoding steps 520306672
552744698 https://github.com/pydata/xarray/pull/3502#issuecomment-552744698 https://api.github.com/repos/pydata/xarray/issues/3502 MDEyOklzc3VlQ29tbWVudDU1Mjc0NDY5OA== andersy005 13301940 2019-11-12T05:47:26Z 2019-11-12T05:47:26Z MEMBER

@dcherian,

You'll have to convert back from the numpy array before exiting that function.

I was able to address this using @shoyer's suggestion above. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Harmonize `FillValue` and `missing_value` during encoding and decoding steps 520306672
552049679 https://github.com/pydata/xarray/pull/3502#issuecomment-552049679 https://api.github.com/repos/pydata/xarray/issues/3502 MDEyOklzc3VlQ29tbWVudDU1MjA0OTY3OQ== andersy005 13301940 2019-11-09T01:13:22Z 2019-11-09T01:21:27Z MEMBER

@dcherian, what is the right way to do the type casting in encode()?

I thought of trying something along these lines:

python encoding["missing_value"] = encoding["missing_value"].astype(data.dtype) However, I quickly realized that this breaks when encoding["missing_value"] is not a numpy object.

EDIT:

I will try using np.asarray():

python encoding["missing_value"] = np.asarray(encoding["missing_value"]).astype(data.dtype)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Harmonize `FillValue` and `missing_value` during encoding and decoding steps 520306672

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);