issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 517855271 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • dcherian · 4 ✖

issue 1

  • Respect user-specified coordinates attribute. · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
564102643 https://github.com/pydata/xarray/pull/3487#issuecomment-564102643 https://api.github.com/repos/pydata/xarray/issues/3487 MDEyOklzc3VlQ29tbWVudDU2NDEwMjY0Mw== dcherian 2448579 2019-12-10T16:01:54Z 2019-12-10T16:02:20Z MEMBER

I'm going to merge this. I'm happy to address any comments in future PRs.

This is a step forward because: 1. This change now lets xarray roundtrip datasets that have "coordinates" attributes specified. 2. It also lets users specify a coordinates attribute and writes it to disk (this raised an error earlier). 3. Xarray should now set the not-CF-compliant "global" coordinates attribute in fewer cases than earlier.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Respect user-specified coordinates attribute. 517855271
553941459 https://github.com/pydata/xarray/pull/3487#issuecomment-553941459 https://api.github.com/repos/pydata/xarray/issues/3487 MDEyOklzc3VlQ29tbWVudDU1Mzk0MTQ1OQ== dcherian 2448579 2019-11-14T15:35:16Z 2019-11-14T15:35:16Z MEMBER

The warnings I added earlier were very annoying so I reworked it.

Now we keep track of all variable names written to a "coordinates" attribute. Any names that are not written are added to a global "coordinates" attribute. I've also fixed the global attribute test to actually test that behaviour :)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Respect user-specified coordinates attribute. 517855271
550108948 https://github.com/pydata/xarray/pull/3487#issuecomment-550108948 https://api.github.com/repos/pydata/xarray/issues/3487 MDEyOklzc3VlQ29tbWVudDU1MDEwODk0OA== dcherian 2448579 2019-11-06T02:08:45Z 2019-11-06T02:08:45Z MEMBER

updated tests and fixed whats-new

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Respect user-specified coordinates attribute. 517855271
549885893 https://github.com/pydata/xarray/pull/3487#issuecomment-549885893 https://api.github.com/repos/pydata/xarray/issues/3487 MDEyOklzc3VlQ29tbWVudDU0OTg4NTg5Mw== dcherian 2448579 2019-11-05T15:58:38Z 2019-11-05T15:58:38Z MEMBER

@jhamman your input would be appreciated here if you have the time.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Respect user-specified coordinates attribute. 517855271

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);