issue_comments

Table actions

6 rows where author_association = "MEMBER", issue = 515662368 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 6 ✖

issue 1

  • drop_vars; deprecate drop for variables · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
551244548 https://github.com/pydata/xarray/pull/3475#issuecomment-551244548 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MTI0NDU0OA== max-sixty 5635139 2019-11-07T20:13:42Z 2019-11-07T20:13:42Z MEMBER

Going to merge given @dcherian 's approval, any other follow-ups I can address in another PR

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
551185004 https://github.com/pydata/xarray/pull/3475#issuecomment-551185004 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MTE4NTAwNA== max-sixty 5635139 2019-11-07T17:36:42Z 2019-11-07T17:36:42Z MEMBER

This is ready to go!

As a reminder, we have PendingDeprecationWarning for drop, which is ignored in user code by default. It does appear in tests, so let me know if that's too strong given the above discussion on backward-compat.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
550499180 https://github.com/pydata/xarray/pull/3475#issuecomment-550499180 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MDQ5OTE4MA== max-sixty 5635139 2019-11-06T21:03:07Z 2019-11-06T21:03:07Z MEMBER

Would drop_labels be better?

I think either is reasonable. drop_sel has the advantage that it's easily comparable to sel, and has the same arguments, so I'd marginally vote for that. Am easily swayed by popular opinion!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
550086071 https://github.com/pydata/xarray/pull/3475#issuecomment-550086071 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MDA4NjA3MQ== max-sixty 5635139 2019-11-06T00:29:42Z 2019-11-06T00:29:42Z MEMBER

@crusaderky let me know if you know off-hand why the MinimumVersionsPolicy is breaking, otherwise I can look into it

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
550083850 https://github.com/pydata/xarray/pull/3475#issuecomment-550083850 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MDA4Mzg1MA== max-sixty 5635139 2019-11-06T00:20:12Z 2019-11-06T00:20:12Z MEMBER

Updated! I used PendingDeprecationWarning, which is default disabled.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
549655830 https://github.com/pydata/xarray/pull/3475#issuecomment-549655830 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU0OTY1NTgzMA== max-sixty 5635139 2019-11-05T04:15:05Z 2019-11-05T04:15:05Z MEMBER

Yes, that sounds reasonable—I think we move documentation and internal usages to drop_sel and drop_vars, and leave drop as a backward compatible option?

Maybe at last a case for FutureDeprecationWarning :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);