issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 514682267 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Errors with mypy 0.740 · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
548145921 https://github.com/pydata/xarray/issues/3467#issuecomment-548145921 https://api.github.com/repos/pydata/xarray/issues/3467 MDEyOklzc3VlQ29tbWVudDU0ODE0NTkyMQ== crusaderky 6213168 2019-10-30T22:51:40Z 2019-10-30T22:51:40Z MEMBER

Correct 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Errors with mypy 0.740 514682267
548072910 https://github.com/pydata/xarray/issues/3467#issuecomment-548072910 https://api.github.com/repos/pydata/xarray/issues/3467 MDEyOklzc3VlQ29tbWVudDU0ODA3MjkxMA== max-sixty 5635139 2019-10-30T19:21:17Z 2019-10-30T19:21:17Z MEMBER

Great, so we can make the change when we upgrade on the next release?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Errors with mypy 0.740 514682267
548066125 https://github.com/pydata/xarray/issues/3467#issuecomment-548066125 https://api.github.com/repos/pydata/xarray/issues/3467 MDEyOklzc3VlQ29tbWVudDU0ODA2NjEyNQ== crusaderky 6213168 2019-10-30T19:03:08Z 2019-10-30T19:03:08Z MEMBER

That's a change in which line mypy expects the type: ignore to be when you have a multi - line function header and only one of the argument trips an error. The only way to make the code pass both 0.730 and 0.740 is put type: ignore in both places, which I'd rather avoid. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Errors with mypy 0.740 514682267
547988634 https://github.com/pydata/xarray/issues/3467#issuecomment-547988634 https://api.github.com/repos/pydata/xarray/issues/3467 MDEyOklzc3VlQ29tbWVudDU0Nzk4ODYzNA== max-sixty 5635139 2019-10-30T16:17:36Z 2019-10-30T16:17:36Z MEMBER

Great!

Are we OK for the Incompatible default too?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Errors with mypy 0.740 514682267
547924243 https://github.com/pydata/xarray/issues/3467#issuecomment-547924243 https://api.github.com/repos/pydata/xarray/issues/3467 MDEyOklzc3VlQ29tbWVudDU0NzkyNDI0Mw== crusaderky 6213168 2019-10-30T14:12:53Z 2019-10-30T14:12:53Z MEMBER

It's a regression in mypy 0.740, already fixed in git tip. https://github.com/python/mypy/issues/7735

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Errors with mypy 0.740 514682267

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);