issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 510937756 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • dcherian · 4 ✖

issue 1

  • Deprecate allow_lazy · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
552949479 https://github.com/pydata/xarray/pull/3435#issuecomment-552949479 https://api.github.com/repos/pydata/xarray/issues/3435 MDEyOklzc3VlQ29tbWVudDU1Mjk0OTQ3OQ== dcherian 2448579 2019-11-12T15:42:08Z 2019-11-12T15:42:08Z MEMBER

Thanks @mathause! I'll merge tomorrow if there are no comments.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate allow_lazy 510937756
551874797 https://github.com/pydata/xarray/pull/3435#issuecomment-551874797 https://api.github.com/repos/pydata/xarray/issues/3435 MDEyOklzc3VlQ29tbWVudDU1MTg3NDc5Nw== dcherian 2448579 2019-11-08T15:36:21Z 2019-11-08T15:36:21Z MEMBER

Now with tests!

ready for review & merge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate allow_lazy 510937756
545707808 https://github.com/pydata/xarray/pull/3435#issuecomment-545707808 https://api.github.com/repos/pydata/xarray/issues/3435 MDEyOklzc3VlQ29tbWVudDU0NTcwNzgwOA== dcherian 2448579 2019-10-24T01:56:53Z 2019-10-24T01:56:53Z MEMBER

@shoyer what do you think of this aggressive deprecation strategy (i.e.treating the current behaviour as a bug and deprecating explicit uses of allow_lazy)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate allow_lazy 510937756
545169567 https://github.com/pydata/xarray/pull/3435#issuecomment-545169567 https://api.github.com/repos/pydata/xarray/issues/3435 MDEyOklzc3VlQ29tbWVudDU0NTE2OTU2Nw== dcherian 2448579 2019-10-22T21:45:02Z 2019-10-22T21:45:17Z MEMBER

This is a breaking change though the previous behaviour could also be considered a bug since we were computing dask arrays by default.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate allow_lazy 510937756

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);