issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 500582648 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • jhamman · 3 ✖

issue 1

  • Rolling minimum dependency versions policy · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
539710597 https://github.com/pydata/xarray/pull/3358#issuecomment-539710597 https://api.github.com/repos/pydata/xarray/issues/3358 MDEyOklzc3VlQ29tbWVudDUzOTcxMDU5Nw== jhamman 2443309 2019-10-08T21:24:12Z 2019-10-08T21:24:12Z MEMBER

Thanks @crusaderky. Good to have this policy solidified. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling minimum dependency versions policy 500582648
539234226 https://github.com/pydata/xarray/pull/3358#issuecomment-539234226 https://api.github.com/repos/pydata/xarray/issues/3358 MDEyOklzc3VlQ29tbWVudDUzOTIzNDIyNg== jhamman 2443309 2019-10-07T22:39:26Z 2019-10-07T22:39:26Z MEMBER

Okay, planning to merge c.COB tomorrow unless there are additional comments.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling minimum dependency versions policy 500582648
539224072 https://github.com/pydata/xarray/pull/3358#issuecomment-539224072 https://api.github.com/repos/pydata/xarray/issues/3358 MDEyOklzc3VlQ29tbWVudDUzOTIyNDA3Mg== jhamman 2443309 2019-10-07T22:04:30Z 2019-10-07T22:04:30Z MEMBER

@crusaderky - this is getting hard to review at this point. Is there more to do or can we merge this in its current state?

I'm +0.5 on moving to 0.14 given the benefits of this and the breaking changes. Any other thoughts?

See #3380 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling minimum dependency versions policy 500582648

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);