issue_comments

Table actions

5 rows where author_association = "MEMBER", issue = 490316894 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 5 ✖

issue 1

  • Hypothesis tests for roundtrip to & from pandas · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
547996494 https://github.com/pydata/xarray/pull/3285#issuecomment-547996494 https://api.github.com/repos/pydata/xarray/issues/3285 MDEyOklzc3VlQ29tbWVudDU0Nzk5NjQ5NA== max-sixty 5635139 2019-10-30T16:33:37Z 2019-10-30T16:33:37Z MEMBER

Thanks @takluyver. And @Zac-HD for the feedback; v much agree with your approach

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hypothesis tests for roundtrip to & from pandas 490316894
547588922 https://github.com/pydata/xarray/pull/3285#issuecomment-547588922 https://api.github.com/repos/pydata/xarray/issues/3285 MDEyOklzc3VlQ29tbWVudDU0NzU4ODkyMg== max-sixty 5635139 2019-10-29T19:23:07Z 2019-10-29T19:23:07Z MEMBER

OK, looks like the test failure now is real. Let me know if you want me to comment out the relevant line so the tests pass.

If we want to merge a subset of the tests then that's fine. Ofc even better if we can use these tests to find & fix the errors

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hypothesis tests for roundtrip to & from pandas 490316894
547587564 https://github.com/pydata/xarray/pull/3285#issuecomment-547587564 https://api.github.com/repos/pydata/xarray/issues/3285 MDEyOklzc3VlQ29tbWVudDU0NzU4NzU2NA== max-sixty 5635139 2019-10-29T19:19:28Z 2019-10-29T19:19:28Z MEMBER

You're right @takluyver

It looks like hypothesis tests are running in the normal test suites. Anyone know offhand why that is? e.g. https://dev.azure.com/xarray/xarray/_build/results?buildId=1284

(that doesn't solve the test failure, though)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hypothesis tests for roundtrip to & from pandas 490316894
547451344 https://github.com/pydata/xarray/pull/3285#issuecomment-547451344 https://api.github.com/repos/pydata/xarray/issues/3285 MDEyOklzc3VlQ29tbWVudDU0NzQ1MTM0NA== max-sixty 5635139 2019-10-29T14:35:37Z 2019-10-29T14:35:37Z MEMBER

This seems so close—could we fix the test (maybe that's just a merging of master?) and merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hypothesis tests for roundtrip to & from pandas 490316894
529197447 https://github.com/pydata/xarray/pull/3285#issuecomment-529197447 https://api.github.com/repos/pydata/xarray/issues/3285 MDEyOklzc3VlQ29tbWVudDUyOTE5NzQ0Nw== max-sixty 5635139 2019-09-08T12:20:34Z 2019-09-08T12:20:34Z MEMBER

This looks great! I'll let someone who knows hypothesis better do a full review. Thanks for submitting @takluyver !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hypothesis tests for roundtrip to & from pandas 490316894

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);