issue_comments

Table actions

5 rows where author_association = "MEMBER", issue = 490316894 and user = 327925 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • takluyver · 5 ✖

issue 1

  • Hypothesis tests for roundtrip to & from pandas · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
547837799 https://github.com/pydata/xarray/pull/3285#issuecomment-547837799 https://api.github.com/repos/pydata/xarray/issues/3285 MDEyOklzc3VlQ29tbWVudDU0NzgzNzc5OQ== takluyver 327925 2019-10-30T10:37:23Z 2019-10-30T10:37:23Z MEMBER

OK, I've xfailed it.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hypothesis tests for roundtrip to & from pandas 490316894
547503432 https://github.com/pydata/xarray/pull/3285#issuecomment-547503432 https://api.github.com/repos/pydata/xarray/issues/3285 MDEyOklzc3VlQ29tbWVudDU0NzUwMzQzMg== takluyver 327925 2019-10-29T16:13:52Z 2019-10-29T16:13:52Z MEMBER

OK, looks like the test failure now is real. Let me know if you want me to comment out the relevant line so the tests pass.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hypothesis tests for roundtrip to & from pandas 490316894
547458156 https://github.com/pydata/xarray/pull/3285#issuecomment-547458156 https://api.github.com/repos/pydata/xarray/issues/3285 MDEyOklzc3VlQ29tbWVudDU0NzQ1ODE1Ng== takluyver 327925 2019-10-29T14:48:52Z 2019-10-29T14:48:52Z MEMBER

Nope. I don't understand the error, though it looks like astropy has had something similar: https://github.com/astropy/astropy/issues/6424

Also black is now failing on a number of files not affected here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hypothesis tests for roundtrip to & from pandas 490316894
547453601 https://github.com/pydata/xarray/pull/3285#issuecomment-547453601 https://api.github.com/repos/pydata/xarray/issues/3285 MDEyOklzc3VlQ29tbWVudDU0NzQ1MzYwMQ== takluyver 327925 2019-10-29T14:40:05Z 2019-10-29T14:40:05Z MEMBER

Merged master, crossing fingers that fixes it.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hypothesis tests for roundtrip to & from pandas 490316894
540987510 https://github.com/pydata/xarray/pull/3285#issuecomment-540987510 https://api.github.com/repos/pydata/xarray/issues/3285 MDEyOklzc3VlQ29tbWVudDU0MDk4NzUxMA== takluyver 327925 2019-10-11T09:20:16Z 2019-10-11T09:20:16Z MEMBER

As in my other PR, one suggested addition causes a test failure, and I've put that in the last commit.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hypothesis tests for roundtrip to & from pandas 490316894

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);