issue_comments

Currently most warnings (> 1500 of 1900) stem from netCDF4. They should be fixed in the newest netCDF4 version (1.5.4). See https://github.com/Unidata/netcdf4-python/blob/master/Changelog (alen -> len and tostring -> tobytes). However, netCDF 1.5.4 can not be installed alongside pynio (conda-forge/pynio-feedstock#90).

Addendum: Removing pynio from the tests and thus using the newest version of netCDF4 brings the warnings down to 71 (from 1931), see #4492

Update! Lots of plotting ones. Pint has had huge progress!

``` =============================== warnings summary =============================== /usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/_pytest/junitxml.py:446 /usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/_pytest/junitxml.py:446: PytestDeprecationWarning: The 'junit_family' default value will change to 'xunit2' in pytest 6.0. See:

from pandas.tseries.frequencies import to_offset df = df.resample(freq="3s").mean() df.index = df.index.to_timestamp() + to_offset("8H")

ds.bar.to_series().resample("24H", loffset="-12H").mean()

xarray/tests/test_dataset.py::test_ndrolling_reduce[True-max-None-True-2] xarray/tests/test_dataset.py::test_ndrolling_reduce[True-max-None-True-2] xarray/tests/test_dataset.py::test_ndrolling_reduce[True-max-None-False-2] xarray/tests/test_dataset.py::test_ndrolling_reduce[True-max-None-False-2] /usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/dask/utils.py:31: RuntimeWarning: All-NaN slice encountered return func(args, *kwargs)

xarray/tests/test_dataset.py::test_ndrolling_reduce[True-max-None-True-2] xarray/tests/test_dataset.py::test_ndrolling_reduce[True-max-None-True-2] xarray/tests/test_dataset.py::test_ndrolling_reduce[True-max-None-False-2] xarray/tests/test_dataset.py::test_ndrolling_reduce[True-max-None-False-2] /usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/dask/core.py:121: RuntimeWarning: All-NaN slice encountered return func(*(_execute_task(a, cache) for a in args))

xarray/tests/test_dataset.py::test_trapz_datetime[np-True] xarray/tests/test_dataset.py::test_trapz_datetime[cftime-True] /usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/dask/array/core.py:1359: FutureWarning: The numpy.trapz function is not implemented by Dask array. You may want to use the da.map_blocks function or something similar to silence this warning. Your code may stop working in a future release. FutureWarning,

xarray/tests/test_distributed.py::test_dask_distributed_cfgrib_integration_test /usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/cfgrib/messages.py:379: RuntimeWarning: deallocating CachingFileManager(<function open at 0x7fc3ffc6acb0>, '/tmp/tmpqgz759fe/temp-2438.tif', mode='r', kwargs={}), but file is not already closed. This may indicate a bug. for i, value in enumerate(header_values):

xarray/tests/test_interp.py::test_decompose[nearest] xarray/tests/test_interp.py::test_decompose[nearest] xarray/tests/test_interp.py::test_decompose[linear] xarray/tests/test_interp.py::test_decompose[linear] /home/vsts/work/1/s/xarray/core/dataarray.py:2060: PendingDeprecationWarning: dropping variables using drop will be deprecated; using drop_vars is encouraged. ds = self._to_temp_dataset().drop(labels, dim, errors=errors)

xarray/tests/test_interp.py::test_interpolate_chunk_advanced[linear] xarray/tests/test_interp.py::test_interpolate_chunk_advanced[nearest] /home/vsts/work/1/s/xarray/core/missing.py:633: PerformanceWarning: Increasing number of chunks by factor of 35 var.transpose(*original_dims).data, x, destination, method, kwargs

xarray/tests/test_interp.py::test_interpolate_chunk_advanced[linear] xarray/tests/test_interp.py::test_interpolate_chunk_advanced[nearest] /home/vsts/work/1/s/xarray/core/missing.py:737: PerformanceWarning: Increasing number of chunks by factor of 35 new_axes=new_axes,

xarray/tests/test_plot.py: 41 warnings /home/vsts/work/1/s/xarray/plot/utils.py:624: MatplotlibDeprecationWarning: The 'extend' parameter to Colorbar has no effect because it is overridden by the mappable; it is deprecated since 3.3 and will be removed two minor releases later. cbar = fig.colorbar(primitive, **cbar_kwargs)

xarray/tests/test_plot.py::TestPlot::test_contourf_cmap_set_with_bad_under_over /home/vsts/work/1/s/xarray/tests/test_plot.py:368: MatplotlibDeprecationWarning: You are modifying the state of a globally registered colormap. In future versions, you will not be able to modify a registered colormap in-place. To remove this warning, you can make a copy of the colormap first. cmap = copy.copy(mpl.cm.get_cmap("viridis")) cmap.set_bad("w")

xarray/tests/test_plot.py::TestPlot::test_contourf_cmap_set_with_bad_under_over /home/vsts/work/1/s/xarray/tests/test_plot.py:375: MatplotlibDeprecationWarning: You are modifying the state of a globally registered colormap. In future versions, you will not be able to modify a registered colormap in-place. To remove this warning, you can make a copy of the colormap first. cmap = copy.copy(mpl.cm.get_cmap("viridis")) cmap.set_under("r")

xarray/tests/test_plot.py::TestPlot::test_contourf_cmap_set_with_bad_under_over /home/vsts/work/1/s/xarray/tests/test_plot.py:379: MatplotlibDeprecationWarning: You are modifying the state of a globally registered colormap. In future versions, you will not be able to modify a registered colormap in-place. To remove this warning, you can make a copy of the colormap first. cmap = copy.copy(mpl.cm.get_cmap("viridis")) cmap.set_over("g")

xarray/tests/test_plot.py::TestDiscreteColorMap::test_discrete_colormap_list_of_levels xarray/tests/test_plot.py::TestDiscreteColorMap::test_discrete_colormap_int_levels xarray/tests/test_plot.py::TestImshow::test_seaborn_palette_as_cmap /home/vsts/work/1/s/xarray/plot/plot.py:903: MatplotlibDeprecationWarning: Passing parameters norm and vmin/vmax simultaneously is deprecated since 3.3 and will become an error two minor releases later. Please pass vmin/vmax directly to the norm when creating it. primitive = ax.imshow(z, **defaults)

xarray/tests/test_plot.py::TestDiscreteColorMap::test_discrete_colormap_list_of_levels xarray/tests/test_plot.py::TestDiscreteColorMap::test_discrete_colormap_int_levels xarray/tests/test_plot.py::TestDiscreteColorMap::test_discrete_colormap_list_levels_and_vmin_or_vmax xarray/tests/test_plot.py::TestPcolormesh::test_seaborn_palette_as_cmap /home/vsts/work/1/s/xarray/plot/plot.py:968: MatplotlibDeprecationWarning: Passing parameters norm and vmin/vmax simultaneously is deprecated since 3.3 and will become an error two minor releases later. Please pass vmin/vmax directly to the norm when creating it. primitive = ax.pcolormesh(x, y, z, **kwargs)

xarray/tests/test_plot.py: 10 warnings /home/vsts/work/1/s/xarray/plot/facetgrid.py:421: MatplotlibDeprecationWarning: The 'extend' parameter to Colorbar has no effect because it is overridden by the mappable; it is deprecated since 3.3 and will be removed two minor releases later. self._mappables[-1], ax=list(self.axes.flat), **kwargs

xarray/tests/test_plot.py::TestPcolormesh::test_dont_infer_interval_breaks_for_cartopy /home/vsts/work/1/s/xarray/plot/plot.py:968: MatplotlibDeprecationWarning: shading='flat' when X and Y have the same dimensions as C is deprecated since 3.3. Either specify the corners of the quadrilaterals with X and Y, or pass shading='auto', 'nearest' or 'gouraud', or set rcParams['pcolor.shading']. This will become an error two minor releases later. primitive = ax.pcolormesh(x, y, z, **kwargs)

xarray/tests/test_plot.py::test_get_axis_cartopy /home/vsts/work/1/s/xarray/plot/utils.py:437: UserWarning: Requested projection is different from current axis projection, creating new axis with requested projection. ax = plt.gca(**kwargs)

xarray/tests/test_sparse.py::test_variable_method[obj.argmax((), {})-True] xarray/tests/test_sparse.py::test_variable_method[obj.argmin((), {})-True] /home/vsts/work/1/s/xarray/tests/test_sparse.py:65: DeprecationWarning: Behaviour of argmin/argmax with neither dim nor axis argument will change to return a dict of indices of each dimension. To get a single, flat index, please use np.argmin(da.data) or np.argmax(da.data) instead of da.argmin() or da.argmax(). return getattr(obj, self.meth)(*self.args, self.kwargs)

xarray/tests/test_sparse.py::test_dataarray_method[obj.argmax((), *{})-True] /home/vsts/work/1/s/xarray/core/dataarray.py:4060: DeprecationWarning: Behaviour of argmin/argmax with neither dim nor axis argument will change to return a dict of indices of each dimension. To get a single, flat index, please use np.argmin(da.data) or np.argmax(da.data) instead of da.argmin() or da.argmax(). result = self.variable.argmax(dim, axis, keep_attrs, skipna)

xarray/tests/test_sparse.py::test_dataarray_method[obj.argmin((), *{})-True] /home/vsts/work/1/s/xarray/core/dataarray.py:3957: DeprecationWarning: Behaviour of argmin/argmax with neither dim nor axis argument will change to return a dict of indices of each dimension. To get a single, flat index, please use np.argmin(da.data) or np.argmax(da.data) instead of da.argmin() or da.argmax(). result = self.variable.argmin(dim, axis, keep_attrs, skipna)

xarray/tests/test_variable.py::TestVariableWithDask::test_pad[xr_arg0-np_arg0-mean] xarray/tests/test_variable.py::TestVariableWithDask::test_pad[xr_arg1-np_arg1-mean] xarray/tests/test_variable.py::TestVariableWithDask::test_pad[xr_arg2-np_arg2-mean] xarray/tests/test_variable.py::TestVariableWithDask::test_pad[xr_arg3-np_arg3-mean] xarray/tests/test_variable.py::TestVariableWithDask::test_pad[xr_arg4-np_arg4-mean] /home/vsts/work/1/s/xarray/core/dask_array_compat.py:142: UserWarning: dask.array.pad(mode="mean") converts integers to floats. xarray converts these floats back to integers to keep the interface consistent. There is a chance that this introduces rounding errors. If you wish to keep the values as floats, first change the dtype to a float before calling pad. UserWarning,

-- Docs: https://docs.pytest.org/en/stable/warnings.html -------- generated xml file: /home/vsts/work/1/s/junit/test-results.xml --------

```

If people want more, here are some from a fresh compilation: https://paste.xinu.at/LnH/

Although it looks like we've regressed, 95% of those (by number, not necessarily effort) are pint

Thanks, @QuLogic