issue_comments

Table actions

6 rows where author_association = "MEMBER", issue = 484499801 and user = 6213168 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • crusaderky · 6 ✖

issue 1

  • __slots__ · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
526578185 https://github.com/pydata/xarray/pull/3250#issuecomment-526578185 https://api.github.com/repos/pydata/xarray/issues/3250 MDEyOklzc3VlQ29tbWVudDUyNjU3ODE4NQ== crusaderky 6213168 2019-08-30T12:13:25Z 2019-08-30T12:13:25Z MEMBER

👍

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   __slots__ 484499801
526087372 https://github.com/pydata/xarray/pull/3250#issuecomment-526087372 https://api.github.com/repos/pydata/xarray/issues/3250 MDEyOklzc3VlQ29tbWVudDUyNjA4NzM3Mg== crusaderky 6213168 2019-08-29T08:40:57Z 2019-08-29T08:40:57Z MEMBER

Ready for merge if there are no additional comments

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   __slots__ 484499801
525253967 https://github.com/pydata/xarray/pull/3250#issuecomment-525253967 https://api.github.com/repos/pydata/xarray/issues/3250 MDEyOklzc3VlQ29tbWVudDUyNTI1Mzk2Nw== crusaderky 6213168 2019-08-27T11:09:02Z 2019-08-27T11:13:37Z MEMBER

Python 3.7: ```python

In [1]: class A(xarray.DataArray): ...: pass ...:
miniconda3/envs/xarray-py37/bin/ipython:1: FutureWarning: xarray subclass A should explicitly define slots

In [2]: a = A()

In [3]: a.x = 1
miniconda3/envs/xarray-py37/bin/ipython:1: FutureWarning: Setting attribute 'x' on a 'A' object. Explicitly define slots to suppress this warning for legitimate custom attributes and raise an error when attempting variables assignments.

In [4]: a.x
Out[4]: 1

In [5]: a.dict
Out[5]: {'x': 1} ```

Python 3.5: Same, but without the first FutureWarning.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   __slots__ 484499801
525253062 https://github.com/pydata/xarray/pull/3250#issuecomment-525253062 https://api.github.com/repos/pydata/xarray/issues/3250 MDEyOklzc3VlQ29tbWVudDUyNTI1MzA2Mg== crusaderky 6213168 2019-08-27T11:05:40Z 2019-08-27T11:05:40Z MEMBER

Added automated unit tests for the automated check on __slots__ for all objects inside the xarray library. I could not find a straightforward way to automatically test that objects defined outside of the library log FutureWarning instead - I tested it by hand.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   __slots__ 484499801
525242799 https://github.com/pydata/xarray/pull/3250#issuecomment-525242799 https://api.github.com/repos/pydata/xarray/issues/3250 MDEyOklzc3VlQ29tbWVudDUyNTI0Mjc5OQ== crusaderky 6213168 2019-08-27T10:32:42Z 2019-08-27T10:32:42Z MEMBER

@shoyer this is theoretically done, however the design I had to come up with to preserve the current statefulness of user-defined accessors displeases me and I'd rather clean it up. See #3268 for design decision.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   __slots__ 484499801
524455456 https://github.com/pydata/xarray/pull/3250#issuecomment-524455456 https://api.github.com/repos/pydata/xarray/issues/3250 MDEyOklzc3VlQ29tbWVudDUyNDQ1NTQ1Ng== crusaderky 6213168 2019-08-23T20:42:04Z 2019-08-23T20:42:04Z MEMBER

@max-sixty any package that for any reason expects xarray objects to have a __dict__ will break overnight. Any package that subclasses from xarray will get a warning. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   __slots__ 484499801

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);