issue_comments

Table actions

6 rows where author_association = "MEMBER", issue = 484015016 and user = 6213168 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • crusaderky · 6 ✖

issue 1

  • tests for arrays with units · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
542924573 https://github.com/pydata/xarray/pull/3238#issuecomment-542924573 https://api.github.com/repos/pydata/xarray/issues/3238 MDEyOklzc3VlQ29tbWVudDU0MjkyNDU3Mw== crusaderky 6213168 2019-10-16T22:56:22Z 2019-10-16T22:56:22Z MEMBER

Also please move the what's new blob from 0.14.0 to 0.14.1

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   tests for arrays with units 484015016
542923962 https://github.com/pydata/xarray/pull/3238#issuecomment-542923962 https://api.github.com/repos/pydata/xarray/issues/3238 MDEyOklzc3VlQ29tbWVudDU0MjkyMzk2Mg== crusaderky 6213168 2019-10-16T22:53:55Z 2019-10-16T22:54:39Z MEMBER

whatsnew.rst: ``` - Added integration tests against pint https://pint.readthedocs.io/_.

.. note::

At the moment of writing, these tests *as well as the ability to use pint in general*
require `a highly experimental version of pint
<https://github.com/andrewgsavage/pint/pull/6>`_ (install with 
``pip install git+https://github.com/andrewgsavage/pint.git@refs/pull/6/head)``.
Even with it, interaction with non-numpy array libraries, e.g. dask or sparse, is broken.

installing.rst - pint <https://pint.readthedocs.io/>_: for units of measure.

.. note::

At the moment of writing, xarray requires a `highly experimental version of pint 
<https://github.com/andrewgsavage/pint/pull/6>`_ (install with
``pip install git+https://github.com/andrewgsavage/pint.git@refs/pull/6/head)``.
Even with it, interaction with non-numpy array libraries, e.g. dask or sparse, is broken.

```

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   tests for arrays with units 484015016
542920960 https://github.com/pydata/xarray/pull/3238#issuecomment-542920960 https://api.github.com/repos/pydata/xarray/issues/3238 MDEyOklzc3VlQ29tbWVudDU0MjkyMDk2MA== crusaderky 6213168 2019-10-16T22:41:50Z 2019-10-16T22:41:50Z MEMBER

@keewis looks good. Also something equivalent in installing.rst on the line that mentions pint, please

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   tests for arrays with units 484015016
542911985 https://github.com/pydata/xarray/pull/3238#issuecomment-542911985 https://api.github.com/repos/pydata/xarray/issues/3238 MDEyOklzc3VlQ29tbWVudDU0MjkxMTk4NQ== crusaderky 6213168 2019-10-16T22:08:17Z 2019-10-16T22:08:17Z MEMBER

@keewis maybe you could clarify where to find this special version and how to get it (pip install https+git://...)? Also I think readers will be much more interested in what they can actually do with pint and what they can't, as opposed to what CI tests we're running.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   tests for arrays with units 484015016
542901674 https://github.com/pydata/xarray/pull/3238#issuecomment-542901674 https://api.github.com/repos/pydata/xarray/issues/3238 MDEyOklzc3VlQ29tbWVudDU0MjkwMTY3NA== crusaderky 6213168 2019-10-16T21:35:39Z 2019-10-16T21:35:39Z MEMBER

@keewis could you tweak whatsnew.rst and installing.rst to set the expectations (very low) for people using the current latest available release of pint?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   tests for arrays with units 484015016
539758682 https://github.com/pydata/xarray/pull/3238#issuecomment-539758682 https://api.github.com/repos/pydata/xarray/issues/3238 MDEyOklzc3VlQ29tbWVudDUzOTc1ODY4Mg== crusaderky 6213168 2019-10-09T00:22:44Z 2019-10-09T00:22:44Z MEMBER

Fixed CI, What's New, and Installing doc

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   tests for arrays with units 484015016

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);