issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 473142248 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 4 ✖

issue 1

  • changed url for rasterio network test · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
515608653 https://github.com/pydata/xarray/pull/3162#issuecomment-515608653 https://api.github.com/repos/pydata/xarray/issues/3162 MDEyOklzc3VlQ29tbWVudDUxNTYwODY1Mw== max-sixty 5635139 2019-07-26T21:44:53Z 2019-07-26T21:44:53Z MEMBER

OK great. Let's at least try and get this passing and turn it green.

Do you have a better idea of why it's still broken? Is it an issue with rasterio (re your comment above)? Is it fixed on master? If not we should open an issue there. If so we could install a later version on that build

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   changed url for rasterio network test 473142248
515546765 https://github.com/pydata/xarray/pull/3162#issuecomment-515546765 https://api.github.com/repos/pydata/xarray/issues/3162 MDEyOklzc3VlQ29tbWVudDUxNTU0Njc2NQ== max-sixty 5635139 2019-07-26T18:02:42Z 2019-07-26T18:02:42Z MEMBER

@scottyhq would you prefer to merge this as-is as an improvement, or wait until the test is fixed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   changed url for rasterio network test 473142248
515546620 https://github.com/pydata/xarray/pull/3162#issuecomment-515546620 https://api.github.com/repos/pydata/xarray/issues/3162 MDEyOklzc3VlQ29tbWVudDUxNTU0NjYyMA== max-sixty 5635139 2019-07-26T18:02:12Z 2019-07-26T18:02:12Z MEMBER

It looks like the flakey test failed but that Azure counts it as passing: https://dev.azure.com/xarray/xarray/_build/results?buildId=389&view=logs

...similar to an allow_failures

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   changed url for rasterio network test 473142248
515284619 https://github.com/pydata/xarray/pull/3162#issuecomment-515284619 https://api.github.com/repos/pydata/xarray/issues/3162 MDEyOklzc3VlQ29tbWVudDUxNTI4NDYxOQ== max-sixty 5635139 2019-07-26T02:29:59Z 2019-07-26T02:29:59Z MEMBER

Thanks @scottyhq !

Did we disable some tests / builds before? If so, shall we re-enable them as part of this PR? (I remember seeing something but wasn't involved directly)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   changed url for rasterio network test 473142248

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);