issue_comments
3 rows where author_association = "MEMBER", issue = 466750687 and user = 6213168 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
issue 1
- black formatting · 3 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
511555108 | https://github.com/pydata/xarray/issues/3092#issuecomment-511555108 | https://api.github.com/repos/pydata/xarray/issues/3092 | MDEyOklzc3VlQ29tbWVudDUxMTU1NTEwOA== | crusaderky 6213168 | 2019-07-15T20:22:28Z | 2019-07-15T20:22:28Z | MEMBER | I tried your setup.cfg above but still getting inconsistencies with black when I have comments in the imports. black: ```python import foo Let me explain why we do thisimport bar ``` isort: ```python import foo Let me explain why we do thisimport bar ``` and I strongly agree with black. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
black formatting 466750687 | |
511552648 | https://github.com/pydata/xarray/issues/3092#issuecomment-511552648 | https://api.github.com/repos/pydata/xarray/issues/3092 | MDEyOklzc3VlQ29tbWVudDUxMTU1MjY0OA== | crusaderky 6213168 | 2019-07-15T20:15:28Z | 2019-07-15T20:15:28Z | MEMBER | I just ran isort on my own project. Overall, it gave me a bunch of good suggestions, but the amount of times I twitched my nose and manually reverted what it did are too many for my tastes. Besides the aforementioned incompatibilities with black, I hate when it changes
So my opinion is: +1 for a manually vetted one-time run; -1 for automatic integration in CI. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
black formatting 466750687 | |
511545508 | https://github.com/pydata/xarray/issues/3092#issuecomment-511545508 | https://api.github.com/repos/pydata/xarray/issues/3092 | MDEyOklzc3VlQ29tbWVudDUxMTU0NTUwOA== | crusaderky 6213168 | 2019-07-15T19:54:30Z | 2019-07-15T19:54:30Z | MEMBER | flake8 is not just about formatting; none of the pyflakes errors (e.g. double/unused imports) are covered by black. I didn't know about isort, nice. However, from a very quick test, it's not compatible with black e.g. if you run black -> isort -> black, the two tools keep touching each other's changes. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
black formatting 466750687 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 1