issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 466750687 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 3 ✖

issue 1

  • black formatting · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
511441494 https://github.com/pydata/xarray/issues/3092#issuecomment-511441494 https://api.github.com/repos/pydata/xarray/issues/3092 MDEyOklzc3VlQ29tbWVudDUxMTQ0MTQ5NA== shoyer 1217238 2019-07-15T15:07:17Z 2019-07-15T15:07:17Z MEMBER

Let's wait a little while for the burst of activity from SciPy to die down first.

On Mon, Jul 15, 2019 at 8:03 AM Maximilian Roos notifications@github.com wrote:

I'm happy to do this today

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/3092?email_source=notifications&email_token=AAJJFVR2KNJP3PXHPG4ZZK3P7SGTXA5CNFSM4IA3BF72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ57I3A#issuecomment-511439980, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVUQ4OMMUZJ5LQEFF7TP7SGTXANCNFSM4IA3BF7Q . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   black formatting 466750687
511175625 https://github.com/pydata/xarray/issues/3092#issuecomment-511175625 https://api.github.com/repos/pydata/xarray/issues/3092 MDEyOklzc3VlQ29tbWVudDUxMTE3NTYyNQ== shoyer 1217238 2019-07-14T05:53:29Z 2019-07-14T05:53:29Z MEMBER

Since Black requires Python >=3.6, which would set the minimum Python version to 3.6 for contributing to xarray (which currently requires Python >= 3.5), are there any plans of dropping Python 3.5 support in the near future?

I don't think these decisions need to be coupled. It's OK to make contributors upgrade to a newer version of Python before all our users.

There are no immediate plans to drop Python 3.5 support, but we haven't really discussed it either. I think it would definitely make sense to drop Python 3.5 after Python 3.8 is available, maybe sooner. Four major Python versions would definitely be too many.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   black formatting 466750687
511054250 https://github.com/pydata/xarray/issues/3092#issuecomment-511054250 https://api.github.com/repos/pydata/xarray/issues/3092 MDEyOklzc3VlQ29tbWVudDUxMTA1NDI1MA== shoyer 1217238 2019-07-12T22:37:58Z 2019-07-12T22:38:15Z MEMBER

+1 from me, too.

It's definitely going to cause some nasty merge conflicts for any work in progress, but hopefully it's straightforward to fix those by running black on the PRs and then merging in master.

We should be able to simply add another job on Azure for this. The lint task using flake8 on Azure's pre-installed Python runs very quickly (less than 30 seconds!) and I would expect to see the same from black.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   black formatting 466750687

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);