home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

7 rows where author_association = "MEMBER" and issue = 454337592 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

  • dcherian 5
  • shoyer 1
  • fmaussion 1

issue 1

  • Add `scales` attributes to Dataset created in open_rasterio (#3012) · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
510127083 https://github.com/pydata/xarray/pull/3013#issuecomment-510127083 https://api.github.com/repos/pydata/xarray/issues/3013 MDEyOklzc3VlQ29tbWVudDUxMDEyNzA4Mw== dcherian 2448579 2019-07-10T16:09:29Z 2019-07-10T16:09:29Z MEMBER

Thanks @ecarrara !

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add `scales` attributes to Dataset created in open_rasterio (#3012) 454337592
509769620 https://github.com/pydata/xarray/pull/3013#issuecomment-509769620 https://api.github.com/repos/pydata/xarray/issues/3013 MDEyOklzc3VlQ29tbWVudDUwOTc2OTYyMA== shoyer 1217238 2019-07-09T19:11:44Z 2019-07-09T19:11:44Z MEMBER

I fixed up the merge. Let's just make sure tests pass...

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add `scales` attributes to Dataset created in open_rasterio (#3012) 454337592
506409703 https://github.com/pydata/xarray/pull/3013#issuecomment-506409703 https://api.github.com/repos/pydata/xarray/issues/3013 MDEyOklzc3VlQ29tbWVudDUwNjQwOTcwMw== dcherian 2448579 2019-06-27T16:05:31Z 2019-06-27T16:05:31Z MEMBER

OK let's remove the mask_flag_enums bits then. I noticed that there's a binary .idx file that was added to. Is that needed?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add `scales` attributes to Dataset created in open_rasterio (#3012) 454337592
501892946 https://github.com/pydata/xarray/pull/3013#issuecomment-501892946 https://api.github.com/repos/pydata/xarray/issues/3013 MDEyOklzc3VlQ29tbWVudDUwMTg5Mjk0Ng== dcherian 2448579 2019-06-13T21:54:11Z 2019-06-13T21:54:11Z MEMBER

Yeah I think @ecarrara found a workaround.

@ecarrara You should also add a note to whats-new and give yourself credit.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add `scales` attributes to Dataset created in open_rasterio (#3012) 454337592
501884771 https://github.com/pydata/xarray/pull/3013#issuecomment-501884771 https://api.github.com/repos/pydata/xarray/issues/3013 MDEyOklzc3VlQ29tbWVudDUwMTg4NDc3MQ== fmaussion 10050469 2019-06-13T21:25:32Z 2019-06-13T21:25:32Z MEMBER

Thanks @ecarrara !

but the TestRasterio::test_serialization fails

This is not the case anymore, right? This test is here to ensure that the dataarrays we are creating with open_rasterio are compatible with the NetCDF model. I think it is good to try to keep it that way.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add `scales` attributes to Dataset created in open_rasterio (#3012) 454337592
501030000 https://github.com/pydata/xarray/pull/3013#issuecomment-501030000 https://api.github.com/repos/pydata/xarray/issues/3013 MDEyOklzc3VlQ29tbWVudDUwMTAzMDAwMA== dcherian 2448579 2019-06-11T21:28:20Z 2019-06-11T21:28:20Z MEMBER

I think we should read and expose all those attributes.

@ecarrara are you up for expanding the scope of your PR? Also, I see you're a "first-time contributor". Welcome! and thanks for contributing!

ping @fmaussion for feedback.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add `scales` attributes to Dataset created in open_rasterio (#3012) 454337592
500872911 https://github.com/pydata/xarray/pull/3013#issuecomment-500872911 https://api.github.com/repos/pydata/xarray/issues/3013 MDEyOklzc3VlQ29tbWVudDUwMDg3MjkxMQ== dcherian 2448579 2019-06-11T14:41:18Z 2019-06-11T14:41:18Z MEMBER

Does rasterio define a set of valid attributes or can you assign arbitrary attributes? If so, should we read and assign all attributes as we do for netCDF files?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add `scales` attributes to Dataset created in open_rasterio (#3012) 454337592

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 14.866ms · About: xarray-datasette
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows