issue_comments

Table actions

5 rows where author_association = "MEMBER", issue = 439823329 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 5 ✖

issue 1

  • BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
491091115 https://github.com/pydata/xarray/pull/2936#issuecomment-491091115 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ5MTA5MTExNQ== max-sixty 5635139 2019-05-09T22:31:01Z 2019-05-09T22:31:01Z MEMBER

Ah, thanks @pletchm , and @shoyer for spotting this

I should have caught this - I didn't separately check the windows tests; I expected the same unrelated failures as on Travis and didn't consider this would be an area that would be different between platforms. Mea culpa. It's always the avenues you least suspect...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329
490515211 https://github.com/pydata/xarray/pull/2936#issuecomment-490515211 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ5MDUxNTIxMQ== max-sixty 5635139 2019-05-08T14:44:32Z 2019-05-08T14:44:32Z MEMBER

Thanks @pletchm !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329
490147560 https://github.com/pydata/xarray/pull/2936#issuecomment-490147560 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ5MDE0NzU2MA== max-sixty 5635139 2019-05-07T16:14:15Z 2019-05-07T16:14:15Z MEMBER

Perfect @pletchm !

Sorry for the test failures on our end - we had some dependency issues.

I'll merge tomorrow unless anyone has other comments.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329
489876173 https://github.com/pydata/xarray/pull/2936#issuecomment-489876173 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ4OTg3NjE3Mw== max-sixty 5635139 2019-05-07T01:55:01Z 2019-05-07T01:55:01Z MEMBER

Then it's fine! They'll be fixed separately.

But did we lose the tests on this branch? Can we add those back?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329
488882173 https://github.com/pydata/xarray/pull/2936#issuecomment-488882173 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ4ODg4MjE3Mw== max-sixty 5635139 2019-05-03T00:57:23Z 2019-05-03T00:57:23Z MEMBER

@pletchm thanks for the PR!

I think the test failuers are dependencies rather than your changes! I kicked off a build of master here: https://travis-ci.org/pydata/xarray/builds/524754660 to confirm - if it's the same failures then we'll know it's not this code

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);