issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 396063731 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • "Timestamp subtraction must have the same timezones or no timezones" when saving a NetCDF · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
454531015 https://github.com/pydata/xarray/issues/2649#issuecomment-454531015 https://api.github.com/repos/pydata/xarray/issues/2649 MDEyOklzc3VlQ29tbWVudDQ1NDUzMTAxNQ== spencerkclark 6628425 2019-01-15T20:02:18Z 2019-01-15T20:02:18Z MEMBER

This was an internal bug in xarray introduced in version 0.11.2, which through #2651 should be fixed in the next release. Probably the cleanest way to work around it for now would be to temporarily downgrade to xarray 0.11.0.

If there is something in xarray > 0.11.0 that you need, another option would be to install the master (unreleased) version of xarray, which includes the bug fix in #2651.

Finally, a cruder workaround (if you want to stick with xarray 0.11.2) in the case that time is encoded with the UTC time zone (and not some other time zone) would be to drop the time zone from the units encoding, e.g. with the example file shared above: ``` In [1]: import xarray

In [2]: ds = xarray.open_dataset('example.nc')

In [3]: ds.time.encoding['units'] Out[3]: 'seconds since 1970-01-01T00:00:00+00:00'

In [4]: ds.time.encoding['units'] = 'seconds since 1970-01-01T00:00:00'

In [5]: ds.to_netcdf('out.nc') ```

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   "Timestamp subtraction must have the same timezones or no timezones" when saving a NetCDF 396063731
451686666 https://github.com/pydata/xarray/issues/2649#issuecomment-451686666 https://api.github.com/repos/pydata/xarray/issues/2649 MDEyOklzc3VlQ29tbWVudDQ1MTY4NjY2Ng== spencerkclark 6628425 2019-01-05T20:08:16Z 2019-01-05T20:08:16Z MEMBER

Agreed, this was my diagnosis too. I'm a bit late, but upon reflection I think I could have written a more comprehensive test in #2651. See #2654 for what I think should be an improvement.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   "Timestamp subtraction must have the same timezones or no timezones" when saving a NetCDF 396063731
451681899 https://github.com/pydata/xarray/issues/2649#issuecomment-451681899 https://api.github.com/repos/pydata/xarray/issues/2649 MDEyOklzc3VlQ29tbWVudDQ1MTY4MTg5OQ== shoyer 1217238 2019-01-05T18:59:23Z 2019-01-05T18:59:23Z MEMBER

For reference, the issue here appears to be that the time variable's units attribute specifies a timezone: int64 time(time) ; time:standard_name = forecast_reference_time ; time:long_name = initial time of forecast ; time:units = seconds since 1970-01-01T00:00:00+00:00 ; time:calendar = proleptic_gregorian ;

And here is the relevant description from CF conventions:

The reference time string (appearing after the identifier since) may include date alone; date and time; or date, time, and time zone. ...

Note: if the time zone is omitted the default is UTC, and if both time and time zone are omitted the default is 00:00:00 UTC.

Given that xarray uses timezone agnostic np.datetime64 and cftime.datetime objects, it does seem like the best course of action here is to decode dates to UTC and then remove the timezone.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   "Timestamp subtraction must have the same timezones or no timezones" when saving a NetCDF 396063731
451583966 https://github.com/pydata/xarray/issues/2649#issuecomment-451583966 https://api.github.com/repos/pydata/xarray/issues/2649 MDEyOklzc3VlQ29tbWVudDQ1MTU4Mzk2Ng== spencerkclark 6628425 2019-01-04T22:12:43Z 2019-01-04T22:12:43Z MEMBER

@matteodefelice thanks for the clear report. This is definitely a regression. See #2651 for a possible fix.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   "Timestamp subtraction must have the same timezones or no timezones" when saving a NetCDF 396063731

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);