issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 393710539 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • Is pep8speaks working well? · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
449774797 https://github.com/pydata/xarray/issues/2627#issuecomment-449774797 https://api.github.com/repos/pydata/xarray/issues/2627 MDEyOklzc3VlQ29tbWVudDQ0OTc3NDc5Nw== max-sixty 5635139 2018-12-24T22:22:04Z 2018-12-24T22:22:04Z MEMBER

Down a level: # flake8: noqa skips a whole file when placed on its own line. # noqa skips a line when placed at the end of the line. I saw a few of the former attempting to do the latter

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Is pep8speaks working well? 393710539
449774747 https://github.com/pydata/xarray/issues/2627#issuecomment-449774747 https://api.github.com/repos/pydata/xarray/issues/2627 MDEyOklzc3VlQ29tbWVudDQ0OTc3NDc0Nw== max-sixty 5635139 2018-12-24T22:21:04Z 2018-12-24T22:21:04Z MEMBER

s strict pep8 compliance supposed to be mandatory in xarray? Sometimes it makes more sense to violate PEP8 to improve readability.

My vote is: - Strict compliance isn't that important, and secondary to readability - Standards, supported by automated checks, ease collaborating and scaling

...so by-and-large do whatever you think is best, but make the checks pass with a comment where the code violates a standard

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Is pep8speaks working well? 393710539
449684619 https://github.com/pydata/xarray/issues/2627#issuecomment-449684619 https://api.github.com/repos/pydata/xarray/issues/2627 MDEyOklzc3VlQ29tbWVudDQ0OTY4NDYxOQ== max-sixty 5635139 2018-12-24T04:26:59Z 2018-12-24T04:26:59Z MEMBER

OK great - I've PRed changes to get back to zero

It would be good if pep8speaks added a check too, but looks like it's not available. We could either: - Add one to travis - Look into Stickler? (It looks online and active, but potentially we had a bad experience last time?) - No system changes, but reviewers are more attentive to the initial pep8speaks comment

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Is pep8speaks working well? 393710539

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);