issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 392535505 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • Fix multiindex selection · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
448817147 https://github.com/pydata/xarray/pull/2621#issuecomment-448817147 https://api.github.com/repos/pydata/xarray/issues/2621 MDEyOklzc3VlQ29tbWVudDQ0ODgxNzE0Nw== shoyer 1217238 2018-12-20T01:07:27Z 2018-12-20T01:07:27Z MEMBER

This issue does not matter only in unstack but also in sel (reindex also?).

Can you explain why matters for .sel()? I guess it slows down repeated indexing?

My inclination was just to copy what pandas does (which is only removing unused levels in unstack)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix multiindex selection 392535505
448677802 https://github.com/pydata/xarray/pull/2621#issuecomment-448677802 https://api.github.com/repos/pydata/xarray/issues/2621 MDEyOklzc3VlQ29tbWVudDQ0ODY3NzgwMg== shoyer 1217238 2018-12-19T17:26:36Z 2018-12-19T17:26:36Z MEMBER

Should we update levels after indexing or when stacking? Pandas does the later: ``` In [31]: import pandas as pd

In [32]: mindex = pd.MultiIndex.from_product([[1, 2, 3], ['a', 'b']])

In [33]: s = pd.Series(range(6), mindex)

In [34]: s.loc[:1].index Out[34]: MultiIndex(levels=[[1, 2, 3], ['a', 'b']], labels=[[0, 0], [0, 1]])

In [35]: s.loc[:1].unstack() Out[35]: a b 1 0 1 ```

The advantage of waiting until unstacking is that removing unused levels could be expensive compared to indexing: it runs in time O(L+N), where L is the size of the original level and N is the length of the new multi-index.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix multiindex selection 392535505

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);