issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 392361367 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Adding mask to open_rasterio · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
867459036 https://github.com/pydata/xarray/pull/2618#issuecomment-867459036 https://api.github.com/repos/pydata/xarray/issues/2618 MDEyOklzc3VlQ29tbWVudDg2NzQ1OTAzNg== keewis 14808389 2021-06-24T08:48:24Z 2021-06-24T08:48:24Z MEMBER

this has been unintentionally closed when renaming the branch to merge into to main, but given that we consider deprecating open_rasterio in favor of the rasterio engine provided by rioxarray (which seems to already support the mask kwarg) that's probably not a mistake. If you disagree feel free to reopen this PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding mask to open_rasterio 392361367
487003189 https://github.com/pydata/xarray/pull/2618#issuecomment-487003189 https://api.github.com/repos/pydata/xarray/issues/2618 MDEyOklzc3VlQ29tbWVudDQ4NzAwMzE4OQ== fmaussion 10050469 2019-04-26T10:02:26Z 2019-04-26T10:02:26Z MEMBER

I'm sorry this has stalled now - I think this is a nice addition.

@jsignell : would you have time to finish this up? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding mask to open_rasterio 392361367
449070341 https://github.com/pydata/xarray/pull/2618#issuecomment-449070341 https://api.github.com/repos/pydata/xarray/issues/2618 MDEyOklzc3VlQ29tbWVudDQ0OTA3MDM0MQ== shoyer 1217238 2018-12-20T17:13:19Z 2018-12-20T17:13:19Z MEMBER

xarray will autoconvert a masked array into a numpy array with NaNs. It probably doesn't make a difference where this happens.

On Thu, Dec 20, 2018 at 9:04 AM Fabien Maussion notifications@github.com wrote:

Do we really want a np.masked_array or do we just want an array with np.Nans in it? I prefer nans, but I guess the downside is type conversion for ints?

Masked arrays come with huge performance drops, I don't think we should use these.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2618#issuecomment-449067569, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1uztASAzUF-7fNanXXJvRWxELml3ks5u68MegaJpZM4ZZMJn . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding mask to open_rasterio 392361367
449067569 https://github.com/pydata/xarray/pull/2618#issuecomment-449067569 https://api.github.com/repos/pydata/xarray/issues/2618 MDEyOklzc3VlQ29tbWVudDQ0OTA2NzU2OQ== fmaussion 10050469 2018-12-20T17:04:30Z 2018-12-20T17:04:30Z MEMBER

Do we really want a np.masked_array or do we just want an array with np.Nans in it? I prefer nans, but I guess the downside is type conversion for ints?

Masked arrays come with huge performance drops, I don't think we should use these.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding mask to open_rasterio 392361367
448542055 https://github.com/pydata/xarray/pull/2618#issuecomment-448542055 https://api.github.com/repos/pydata/xarray/issues/2618 MDEyOklzc3VlQ29tbWVudDQ0ODU0MjA1NQ== fmaussion 10050469 2018-12-19T10:15:33Z 2018-12-19T10:15:33Z MEMBER

I wonder if nodatavals is the only attribute for masking - in the doc (https://rasterio.readthedocs.io/en/latest/topics/masks.html) they also mention nodata, which in my experience is also used

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding mask to open_rasterio 392361367

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);