issue_comments

Table actions

21 rows where author_association = "MEMBER" and issue = 373574495 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • xarray 0.11 release · 21 ✖

author_association 1

  • MEMBER · 21 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
436751105 https://github.com/pydata/xarray/issues/2505#issuecomment-436751105 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNjc1MTEwNQ== shoyer 1217238 2018-11-07T19:38:39Z 2018-11-07T19:38:39Z MEMBER

Generally I always favor the most granular dependency specifications, but this seems like something conda-forge could decide as a matter of policy. If they don't want to rule on a general policy, then yes let's drop optional conda deps to match pypi.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
436707493 https://github.com/pydata/xarray/issues/2505#issuecomment-436707493 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNjcwNzQ5Mw== jhamman 2443309 2018-11-07T17:27:57Z 2018-11-07T17:27:57Z MEMBER

Related and something I could use feedback from @pydata/xarray on: should we drop optional deps from the conda-forge build: https://github.com/conda-forge/xarray-feedstock/pull/37

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
436686085 https://github.com/pydata/xarray/issues/2505#issuecomment-436686085 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNjY4NjA4NQ== jhamman 2443309 2018-11-07T16:29:53Z 2018-11-07T16:29:53Z MEMBER

Thanks @shoyer! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
436684494 https://github.com/pydata/xarray/issues/2505#issuecomment-436684494 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNjY4NDQ5NA== shoyer 1217238 2018-11-07T16:25:52Z 2018-11-07T16:25:52Z MEMBER

I just tagged the release and uploaded it to pypi. RTD and conda forge should follow soon automatically.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
436497197 https://github.com/pydata/xarray/issues/2505#issuecomment-436497197 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNjQ5NzE5Nw== shoyer 1217238 2018-11-07T04:01:16Z 2018-11-07T04:01:16Z MEMBER

see https://github.com/pydata/xarray/pull/2548 for some minor reorganization of the release notes

On Tue, Nov 6, 2018 at 7:57 PM Joe Hamman notifications@github.com wrote:

I'm observing that our checklist seems to be complete. Are we blocked on any outstanding issues?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/2505#issuecomment-436464907, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1n0lnPnS0XcLgOvEro2PN5JoGTIMks5usjAHgaJpZM4X4V2i . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
436464907 https://github.com/pydata/xarray/issues/2505#issuecomment-436464907 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNjQ2NDkwNw== jhamman 2443309 2018-11-07T00:57:42Z 2018-11-07T00:57:42Z MEMBER

I'm observing that our checklist seems to be complete. Are we blocked on any outstanding issues?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
432741534 https://github.com/pydata/xarray/issues/2505#issuecomment-432741534 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMjc0MTUzNA== dcherian 2448579 2018-10-24T16:58:51Z 2018-11-04T19:03:27Z MEMBER
  • [x] #2444 is a small bugfix for facetgrid that's ready for review.

These PRs seem to be almost done (it'd be nice to get some of these in):

2470 (fill_value in shift)

2449 (to_iris, from_iris)

2207 (something about chunksizes)

2415 (test for 1D object indexing)

2413 (positional arguments for groupby apply)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
435622842 https://github.com/pydata/xarray/issues/2505#issuecomment-435622842 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNTYyMjg0Mg== shoyer 1217238 2018-11-03T21:38:17Z 2018-11-03T21:38:17Z MEMBER

Another deprecation cycle to finish would be the old resample() syntax.

I got started on this one...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
434484745 https://github.com/pydata/xarray/issues/2505#issuecomment-434484745 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNDQ4NDc0NQ== dcherian 2448579 2018-10-30T21:56:42Z 2018-10-30T21:57:24Z MEMBER

(commented on wrong issue)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
434477760 https://github.com/pydata/xarray/issues/2505#issuecomment-434477760 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNDQ3Nzc2MA== shoyer 1217238 2018-10-30T21:31:58Z 2018-10-30T21:31:58Z MEMBER

Another deprecation cycle to finish would be the old resample() syntax.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433257199 https://github.com/pydata/xarray/issues/2505#issuecomment-433257199 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzI1NzE5OQ== spencerkclark 6628425 2018-10-26T01:31:34Z 2018-10-26T01:31:34Z MEMBER

@shoyer sure thing, barring feedback from others, I'll try and put a PR together tomorrow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433255897 https://github.com/pydata/xarray/issues/2505#issuecomment-433255897 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzI1NTg5Nw== shoyer 1217238 2018-10-26T01:22:26Z 2018-10-26T01:22:26Z MEMBER

@spencerkclark I also think this is probably a good idea. If you have time, it would be great if you could put together a PR to switch the behavior.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433254999 https://github.com/pydata/xarray/issues/2505#issuecomment-433254999 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzI1NDk5OQ== spencerkclark 6628425 2018-10-26T01:16:28Z 2018-10-26T01:16:28Z MEMBER

should we switch the default behavior to use cftime for non-standard calendars in 0.11?

I would be +1 on this; as evidenced by #2437 it has become increasingly confusing/error-prone to use non-standard/out-of-range dates without CFTimeIndex enabled. That said, since not everything is enabled yet (namely resample and plotting), I'd be sympathetic to those who would rather wait a bit longer.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433235743 https://github.com/pydata/xarray/issues/2505#issuecomment-433235743 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzIzNTc0Mw== shoyer 1217238 2018-10-25T23:13:11Z 2018-10-25T23:13:11Z MEMBER

@spencerkclark and other climate scientists: should we switch the default behavior to use cftime for non-standard calendars in 0.11? (see https://github.com/pydata/xarray/issues/2437)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433133764 https://github.com/pydata/xarray/issues/2505#issuecomment-433133764 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzEzMzc2NA== fmaussion 10050469 2018-10-25T17:15:54Z 2018-10-25T17:15:54Z MEMBER

Did any other library have a warning for this? I think that if we follow the lead of ipython, matplotlib and https://python3statement.org/ then all we have to do is make 0.12 non-installable on py2, and py2 users will stick to 0.11 ad vitam æternam.

It would be quite mean to have them listen to a warning all the time they import xarray on top of that :smile:

ipython docs have a big warning banner though 

{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433098754 https://github.com/pydata/xarray/issues/2505#issuecomment-433098754 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzA5ODc1NA== jhamman 2443309 2018-10-25T15:33:53Z 2018-10-25T15:33:53Z MEMBER

Python 2 users know the end is near.

Based on recent experience, I'm not quite as confident here 😄 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433096681 https://github.com/pydata/xarray/issues/2505#issuecomment-433096681 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzA5NjY4MQ== shoyer 1217238 2018-10-25T15:28:38Z 2018-10-25T15:28:38Z MEMBER

Would it make sense to add a deprecation warning for Python2 users in this release (xref #1876). Chances are, 0.12 will come after Jan-2019 when we're slated to drop Python2 support.

I agree, this will probably be the last major xarray release with Python 2 support. But I don't think there's much to be gained by adding a warning -- Python 2 users know the end is near.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433093555 https://github.com/pydata/xarray/issues/2505#issuecomment-433093555 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzA5MzU1NQ== jhamman 2443309 2018-10-25T15:20:41Z 2018-10-25T15:20:41Z MEMBER

Would it make sense to add a deprecation warning for Python2 users in this release (xref #1876). Chances are, 0.12 will come after Jan-2019 when we're slated to drop Python2 support.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
432878130 https://github.com/pydata/xarray/issues/2505#issuecomment-432878130 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMjg3ODEzMA== dcherian 2448579 2018-10-25T01:05:22Z 2018-10-25T01:05:22Z MEMBER

Oooh we're supposed to remove .T as an alias for .transpose() #1232. finally!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
432745366 https://github.com/pydata/xarray/issues/2505#issuecomment-432745366 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMjc0NTM2Ng== max-sixty 5635139 2018-10-24T17:08:26Z 2018-10-24T17:08:26Z MEMBER

I'll do Iterating over a Dataset iterates only over its data_vars

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
432743053 https://github.com/pydata/xarray/issues/2505#issuecomment-432743053 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMjc0MzA1Mw== rabernat 1197350 2018-10-24T17:02:10Z 2018-10-24T17:02:24Z MEMBER

Would be nice to get #2487 finished before release. (zarr chunking bug)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);