issue_comments

Table actions

13 rows where author_association = "MEMBER" and issue = 366653476 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: body, reactions, created_at (date), updated_at (date)

issue 1

  • pep8speaks · 13 ✖

author_association 1

  • MEMBER · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
427693332 https://github.com/pydata/xarray/pull/2462#issuecomment-427693332 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNzY5MzMzMg== shoyer 1217238 2018-10-07T22:40:15Z 2018-10-07T22:40:15Z MEMBER

👍 Let's give this is a try

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
427680656 https://github.com/pydata/xarray/pull/2462#issuecomment-427680656 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNzY4MDY1Ng== fujiisoup 6815844 2018-10-07T19:39:18Z 2018-10-07T19:39:18Z MEMBER

I just updated .pep8speaks.yml that is taken from pandas-dev/pandas. If there are no further comments, I would merge this. Let's see how it works with this configuration.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
427649012 https://github.com/pydata/xarray/pull/2462#issuecomment-427649012 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNzY0OTAxMg== fmaussion 10050469 2018-10-07T12:19:27Z 2018-10-07T12:19:27Z MEMBER

Weird that @stickler-ci broke. We're still using it at pandas-gbq and it's working well.

I could try to reactivate it now that I've deactivated it. Still suspicious that clicking @stickler-ci gives a 404 error.

I like pep8speaks for it's less verbose messaging (all in one message that gets updated after each new commit) and for the fact that pandas is also using it, but I have no strong opinion about it.

If we use pep8speaks we should use the same config as pandas though, and we should ask them about #noqa : done here: https://github.com/OrkoHunter/pep8speaks/issues/96

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
427597384 https://github.com/pydata/xarray/pull/2462#issuecomment-427597384 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNzU5NzM4NA== max-sixty 5635139 2018-10-06T18:45:49Z 2018-10-06T18:45:49Z MEMBER

OK. Though if people make changes to # noqa lines, we'll have false positives.

Weird that @stickler-ci broke. We're still using it at pandas-gbq and it's working well. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
427585414 https://github.com/pydata/xarray/pull/2462#issuecomment-427585414 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNzU4NTQxNA== fmaussion 10050469 2018-10-06T16:04:40Z 2018-10-06T16:04:40Z MEMBER

I also have the impression that noqa are ignored by pep8speask, although I haven't seen any related issue on their repo. Probably another reason for a diff_only option for now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
427584659 https://github.com/pydata/xarray/pull/2462#issuecomment-427584659 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNzU4NDY1OQ== max-sixty 5635139 2018-10-06T15:54:19Z 2018-10-06T15:54:19Z MEMBER

Good point.

That's odd - I don't get those on #2467, or locally.

Is there an issue around ignoring # noqa?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
427584175 https://github.com/pydata/xarray/pull/2462#issuecomment-427584175 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNzU4NDE3NQ== fmaussion 10050469 2018-10-06T15:47:58Z 2018-10-06T15:47:58Z MEMBER

Why do we need diff_only

I was worried about all the unrelated pep8 errors on this PR: https://github.com/pydata/xarray/pull/2463

Although I'm not sure where they come from.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
427583195 https://github.com/pydata/xarray/pull/2462#issuecomment-427583195 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNzU4MzE5NQ== max-sixty 5635139 2018-10-06T15:33:43Z 2018-10-06T15:33:43Z MEMBER

I think we need a set-up file to set diff_only on PR

Why do we need diff_only? The repo passes flake8 as a whole on my local

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
427583089 https://github.com/pydata/xarray/pull/2462#issuecomment-427583089 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNzU4MzA4OQ== max-sixty 5635139 2018-10-06T15:32:23Z 2018-10-06T15:32:23Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
427042220 https://github.com/pydata/xarray/pull/2462#issuecomment-427042220 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNzA0MjIyMA== fmaussion 10050469 2018-10-04T14:33:26Z 2018-10-04T14:33:26Z MEMBER

I think we need a set-up file to set diff_only on PR. See the pandas pep8speaks template: https://github.com/pandas-dev/pandas/blob/master/.pep8speaks.yml

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
426935090 https://github.com/pydata/xarray/pull/2462#issuecomment-426935090 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNjkzNTA5MA== fmaussion 10050469 2018-10-04T08:43:15Z 2018-10-04T08:43:15Z MEMBER

Thanks! I just switched off stickler which is still broken anyway. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
426926612 https://github.com/pydata/xarray/pull/2462#issuecomment-426926612 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNjkyNjYxMg== fujiisoup 6815844 2018-10-04T08:15:54Z 2018-10-04T08:15:54Z MEMBER

@pep8speaks suggest the diff

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476
426912405 https://github.com/pydata/xarray/pull/2462#issuecomment-426912405 https://api.github.com/repos/pydata/xarray/issues/2462 MDEyOklzc3VlQ29tbWVudDQyNjkxMjQwNQ== fujiisoup 6815844 2018-10-04T07:23:32Z 2018-10-04T07:23:32Z MEMBER

@pep8speaks suggest the diff

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pep8speaks 366653476

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);