issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 344631360 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Behavior of filter_by_attrs() does not match netCDF4.Dataset.get_variables_by_attributes · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
408274199 https://github.com/pydata/xarray/issues/2315#issuecomment-408274199 https://api.github.com/repos/pydata/xarray/issues/2315 MDEyOklzc3VlQ29tbWVudDQwODI3NDE5OQ== shoyer 1217238 2018-07-27T00:22:13Z 2018-07-27T00:22:13Z MEMBER

I agree, I think we can change the behavior here to something more rationale. Arguably the existing behavior is a bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Behavior of filter_by_attrs() does not match netCDF4.Dataset.get_variables_by_attributes 344631360
408254512 https://github.com/pydata/xarray/issues/2315#issuecomment-408254512 https://api.github.com/repos/pydata/xarray/issues/2315 MDEyOklzc3VlQ29tbWVudDQwODI1NDUxMg== shoyer 1217238 2018-07-26T22:27:59Z 2018-07-26T22:27:59Z MEMBER

Looking at the original PR (https://github.com/pydata/xarray/pull/844), it appears that this scenario was not directly contemplated. I don't see any test coverage.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Behavior of filter_by_attrs() does not match netCDF4.Dataset.get_variables_by_attributes 344631360
408246470 https://github.com/pydata/xarray/issues/2315#issuecomment-408246470 https://api.github.com/repos/pydata/xarray/issues/2315 MDEyOklzc3VlQ29tbWVudDQwODI0NjQ3MA== shoyer 1217238 2018-07-26T21:52:14Z 2018-07-26T21:52:14Z MEMBER

cc @ocefpaf, who contributed this method originally

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Behavior of filter_by_attrs() does not match netCDF4.Dataset.get_variables_by_attributes 344631360

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);