issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 341664808 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • ENH: format_array_flat() always displays first and last items. · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
406646504 https://github.com/pydata/xarray/pull/2293#issuecomment-406646504 https://api.github.com/repos/pydata/xarray/issues/2293 MDEyOklzc3VlQ29tbWVudDQwNjY0NjUwNA== shoyer 1217238 2018-07-20T16:05:05Z 2018-07-20T16:05:05Z MEMBER

Thank you!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: format_array_flat() always displays first and last items. 341664808
406637563 https://github.com/pydata/xarray/pull/2293#issuecomment-406637563 https://api.github.com/repos/pydata/xarray/issues/2293 MDEyOklzc3VlQ29tbWVudDQwNjYzNzU2Mw== shoyer 1217238 2018-07-20T15:34:43Z 2018-07-20T15:34:43Z MEMBER

OK looks good to me. Can you kindly add a brief release note, since this is user visible?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: format_array_flat() always displays first and last items. 341664808
406486226 https://github.com/pydata/xarray/pull/2293#issuecomment-406486226 https://api.github.com/repos/pydata/xarray/issues/2293 MDEyOklzc3VlQ29tbWVudDQwNjQ4NjIyNg== shoyer 1217238 2018-07-20T04:31:57Z 2018-07-20T04:31:57Z MEMBER

One slight oddity is that formatting.format_array_flat(np.arange(4), 0) returns 0 ... 3 even though 0 1 2 3 would take up the same number of characters. I'm not inclined to add a special case for this, but let me know if you think I should.

Yeah, I don't think we'll be passing in a max length of 0 very often :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: format_array_flat() always displays first and last items. 341664808

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);