issue_comments

Table actions

1 row where author_association = "MEMBER", issue = 340069538 and user = 1197350 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • rabernat · 1 ✖

issue 1

  • ENH: Scatter plots of one variable vs another · 1 ✖

author_association 1

  • MEMBER · 1 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
405081849 https://github.com/pydata/xarray/pull/2277#issuecomment-405081849 https://api.github.com/repos/pydata/xarray/issues/2277 MDEyOklzc3VlQ29tbWVudDQwNTA4MTg0OQ== rabernat 1197350 2018-07-15T10:31:31Z 2018-07-15T10:31:31Z MEMBER

This seems like a very cool and useful feature! A few comments:

  • This should probably live under the .plot namespace, i.e. da.plot.scatter rather than da.scatter.
  • You should try to emulate the pandas scatter api as much as possible (which itself emulates the matplotlib api). That means using the c keyword instead of hue and also implementing s for size

Happy to provide a more detailed review once the tests are implemented. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Scatter plots of one variable vs another 340069538

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);