issue_comments

Table actions

10 rows where author_association = "MEMBER", issue = 333248242 and user = 6815844 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • fujiisoup · 10 ✖

issue 1

  • Refactor nanops · 10 ✖

author_association 1

  • MEMBER · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
424700785 https://github.com/pydata/xarray/pull/2236#issuecomment-424700785 https://api.github.com/repos/pydata/xarray/issues/2236 MDEyOklzc3VlQ29tbWVudDQyNDcwMDc4NQ== fujiisoup 6815844 2018-09-26T12:42:55Z 2018-09-26T12:42:55Z MEMBER

Thanks, @st-bender, for the bug report. I copied your comment to #2440.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor nanops 333248242
413446001 https://github.com/pydata/xarray/pull/2236#issuecomment-413446001 https://api.github.com/repos/pydata/xarray/issues/2236 MDEyOklzc3VlQ29tbWVudDQxMzQ0NjAwMQ== fujiisoup 6815844 2018-08-16T06:59:37Z 2018-08-16T06:59:37Z MEMBER

Thanks for the review. Merging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor nanops 333248242
413431477 https://github.com/pydata/xarray/pull/2236#issuecomment-413431477 https://api.github.com/repos/pydata/xarray/issues/2236 MDEyOklzc3VlQ29tbWVudDQxMzQzMTQ3Nw== fujiisoup 6815844 2018-08-16T05:37:25Z 2018-08-16T05:37:25Z MEMBER

Thanks, @shoyer. All done.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor nanops 333248242
412249461 https://github.com/pydata/xarray/pull/2236#issuecomment-412249461 https://api.github.com/repos/pydata/xarray/issues/2236 MDEyOklzc3VlQ29tbWVudDQxMjI0OTQ2MQ== fujiisoup 6815844 2018-08-11T04:15:30Z 2018-08-11T04:15:30Z MEMBER

Can anyone give further review?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor nanops 333248242
412249224 https://github.com/pydata/xarray/pull/2236#issuecomment-412249224 https://api.github.com/repos/pydata/xarray/issues/2236 MDEyOklzc3VlQ29tbWVudDQxMjI0OTIyNA== fujiisoup 6815844 2018-08-11T04:08:59Z 2018-08-11T04:08:59Z MEMBER

I noticed min_count is working also on resampled object. Your issue might be for the API of resample.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor nanops 333248242
412246496 https://github.com/pydata/xarray/pull/2236#issuecomment-412246496 https://api.github.com/repos/pydata/xarray/issues/2236 MDEyOklzc3VlQ29tbWVudDQxMjI0NjQ5Ng== fujiisoup 6815844 2018-08-11T03:00:13Z 2018-08-11T03:00:13Z MEMBER

@rpnaut

Thanks for testing.

Your min_count argument is not allowed for type 'dataset' but only for type 'dataarray'. Starting with the dataset located here:

I think it is not true. It works on Dataset, but not on resampled object. I will raise a issue for this later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor nanops 333248242
403272397 https://github.com/pydata/xarray/pull/2236#issuecomment-403272397 https://api.github.com/repos/pydata/xarray/issues/2236 MDEyOklzc3VlQ29tbWVudDQwMzI3MjM5Nw== fujiisoup 6815844 2018-07-08T08:40:55Z 2018-07-08T08:40:55Z MEMBER

I think this is ready for another review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor nanops 333248242
399279344 https://github.com/pydata/xarray/pull/2236#issuecomment-399279344 https://api.github.com/repos/pydata/xarray/issues/2236 MDEyOklzc3VlQ29tbWVudDM5OTI3OTM0NA== fujiisoup 6815844 2018-06-21T23:59:48Z 2018-06-21T23:59:48Z MEMBER

Thanks, @rpnaut . Actually, I'm changing the code also around sum. So it looks my change caused the bug you reported. I think we do not have a good test coverage around the dataset.reduction.

I will add the test also. Thanks again for the testing :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor nanops 333248242
399278523 https://github.com/pydata/xarray/pull/2236#issuecomment-399278523 https://api.github.com/repos/pydata/xarray/issues/2236 MDEyOklzc3VlQ29tbWVudDM5OTI3ODUyMw== fujiisoup 6815844 2018-06-21T23:54:23Z 2018-06-21T23:54:23Z MEMBER

@shoyer , thanks for the details. I think I understood your idea. This sounds a cleaner solution. I will update the code again, but it will take some more days (or a week).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor nanops 333248242
398926990 https://github.com/pydata/xarray/pull/2236#issuecomment-398926990 https://api.github.com/repos/pydata/xarray/issues/2236 MDEyOklzc3VlQ29tbWVudDM5ODkyNjk5MA== fujiisoup 6815844 2018-06-20T23:17:12Z 2018-06-20T23:17:12Z MEMBER

I think it would make sense to restructure this a little bit to have two well defined layers:

A module of bottleneck/numpy functions that act on numpy arrays only. A module of functions that act on numpy or dask arrays (or these could be moved into duck_array_ops).

Could you explain more detail about this idea?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor nanops 333248242

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);