issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 332471780 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

issue 1

  • Problem opening unstructured grid ocean forecasts with 4D vertical coordinates · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1171369192 https://github.com/pydata/xarray/issues/2233#issuecomment-1171369192 https://api.github.com/repos/pydata/xarray/issues/2233 IC_kwDOAMm_X85F0azo benbovy 4160723 2022-06-30T15:34:44Z 2022-06-30T15:34:44Z MEMBER

In any case I just updated and tried without doing anything new and it didn't work

Yes it is not yet implemented, still on the todo list (see 2nd item in #6293).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Problem opening unstructured grid ocean forecasts with 4D vertical coordinates 332471780
1078641356 https://github.com/pydata/xarray/issues/2233#issuecomment-1078641356 https://api.github.com/repos/pydata/xarray/issues/2233 IC_kwDOAMm_X85ASsLM dcherian 2448579 2022-03-25T04:24:46Z 2022-03-25T06:24:37Z MEMBER

in theory, yes!

Perhaps @benbovy can provide some guidance on what needs to happen next.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Problem opening unstructured grid ocean forecasts with 4D vertical coordinates 332471780
1078695337 https://github.com/pydata/xarray/issues/2233#issuecomment-1078695337 https://api.github.com/repos/pydata/xarray/issues/2233 IC_kwDOAMm_X85AS5Wp shoyer 1217238 2022-03-25T06:20:10Z 2022-03-25T06:20:10Z MEMBER

This is the second follow-up item in https://github.com/pydata/xarray/issues/6293

I think we could definitely experiment with relaxing this constraint now, although ideally we would continue to check off auditing all of the methods in that long list first.

 
{
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Problem opening unstructured grid ocean forecasts with 4D vertical coordinates 332471780
397602084 https://github.com/pydata/xarray/issues/2233#issuecomment-397602084 https://api.github.com/repos/pydata/xarray/issues/2233 MDEyOklzc3VlQ29tbWVudDM5NzYwMjA4NA== rabernat 1197350 2018-06-15T12:12:37Z 2018-06-15T12:12:37Z MEMBER

Ok I see...the basic problem, as @shoyer says, is that siglay is used as a dimension coordinate, but it siglay itself is two-dimensional: siglay(siglay, node). Xarray can't fit this into its notion of coordinates.

This defines a nice specific problem to solve for the index refactoring.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Problem opening unstructured grid ocean forecasts with 4D vertical coordinates 332471780
397370518 https://github.com/pydata/xarray/issues/2233#issuecomment-397370518 https://api.github.com/repos/pydata/xarray/issues/2233 MDEyOklzc3VlQ29tbWVudDM5NzM3MDUxOA== shoyer 1217238 2018-06-14T17:12:35Z 2018-06-14T17:12:35Z MEMBER

We currently enforce the requirement that non-1D variable cannot be assigned in a Dataset with a name that matches one of their dimensions. This is somewhat useful, because it means that dataset.variables[dim] is guaranteed to be a 1D set of coordinate labels, in the form of a xarray.IndexVariable backed by a pandas.Index.

It might make sense to relax this requirements part of the eventual "explicit indexes" refactor (https://github.com/pydata/xarray/issues/1603). Then the right way to get out an index will simply be dataset.indexes[dim] (which may or may not exist). However, this would definitely be a breaking change: it is likely that at least some code (inside and outside xarray) relies on this assumption.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Problem opening unstructured grid ocean forecasts with 4D vertical coordinates 332471780
397367957 https://github.com/pydata/xarray/issues/2233#issuecomment-397367957 https://api.github.com/repos/pydata/xarray/issues/2233 MDEyOklzc3VlQ29tbWVudDM5NzM2Nzk1Nw== rabernat 1197350 2018-06-14T17:04:31Z 2018-06-14T17:04:31Z MEMBER

@rsignell-usgs -- could you print the ncdump for the file?

Is there some documentation on these new additions to CF conventions that you can point us to? We need to develop a comprehensive strategy towards supporting whatever is in there from xarray. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Problem opening unstructured grid ocean forecasts with 4D vertical coordinates 332471780

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);