issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 331668890 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • dcherian · 4 ✖

issue 1

  • Slow performance of isel · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1468649950 https://github.com/pydata/xarray/issues/2227#issuecomment-1468649950 https://api.github.com/repos/pydata/xarray/issues/2227 IC_kwDOAMm_X85XidHe dcherian 2448579 2023-03-14T18:49:51Z 2023-03-14T18:54:16Z MEMBER

A reproducible example would help but indexing with dask arrays is a bit limited.

On https://github.com/pydata/xarray/pull/5873 it's possible it will raise an error and ask you to compute the indexer. Also see https://github.com/dask/dask/issues/4156

EDIT: your slowdown is probably because it's compuing Sn multiple times. You could speed it up by calling compute once and passing a numpy array to isel

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Slow performance of isel 331668890
558700154 https://github.com/pydata/xarray/issues/2227#issuecomment-558700154 https://api.github.com/repos/pydata/xarray/issues/2227 MDEyOklzc3VlQ29tbWVudDU1ODcwMDE1NA== dcherian 2448579 2019-11-26T16:08:24Z 2019-11-26T16:08:24Z MEMBER

I don't know much about indexing but that PR propagates a "new" indexes property as part of #1603 (work towards enabling more flexible indexing), it doesn't change anything about "indexing". I think the dask docs may be more relevant to what you may be asking about: https://docs.dask.org/en/latest/array-slicing.html

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Slow performance of isel 331668890
533119743 https://github.com/pydata/xarray/issues/2227#issuecomment-533119743 https://api.github.com/repos/pydata/xarray/issues/2227 MDEyOklzc3VlQ29tbWVudDUzMzExOTc0Mw== dcherian 2448579 2019-09-19T13:00:40Z 2019-09-19T13:00:40Z MEMBER

I think align tries to optimize that case, so maybe something's also possible there?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Slow performance of isel 331668890
532780068 https://github.com/pydata/xarray/issues/2227#issuecomment-532780068 https://api.github.com/repos/pydata/xarray/issues/2227 MDEyOklzc3VlQ29tbWVudDUzMjc4MDA2OA== dcherian 2448579 2019-09-18T17:14:38Z 2019-09-18T17:14:38Z MEMBER

On master I'm seeing

``` %timeit ds.a.isel(time=time_filter) 3.65 s ± 29.4 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%timeit ds.a.isel(time=time_filter.values) 2.99 s ± 15 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%timeit ds.a.values[time_filter] 227 ms ± 6.59 ms per loop (mean ± std. dev. of 7 runs, 1 loop each) ```

Can someone else reproduce?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Slow performance of isel 331668890

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);