issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 328439361 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • jhamman · 2 ✖

issue 1

  • Fixes #2198: Drop chunksizes when only when original_shape is different, not when it isn't found · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
393910599 https://github.com/pydata/xarray/pull/2207#issuecomment-393910599 https://api.github.com/repos/pydata/xarray/issues/2207 MDEyOklzc3VlQ29tbWVudDM5MzkxMDU5OQ== jhamman 2443309 2018-06-01T15:10:04Z 2018-06-01T15:10:04Z MEMBER

BTW, all the tests you mention above seem to have passed on CI so I'm guessing its something to do with your environment. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixes #2198: Drop chunksizes when only when original_shape is different, not when it isn't found 328439361
393910401 https://github.com/pydata/xarray/pull/2207#issuecomment-393910401 https://api.github.com/repos/pydata/xarray/issues/2207 MDEyOklzc3VlQ29tbWVudDM5MzkxMDQwMQ== jhamman 2443309 2018-06-01T15:09:25Z 2018-06-01T15:09:25Z MEMBER

This looks good to me. Can we add a regression test to make sure we're covering the desired behavior here? Also, this warrants a note in the what's new section of the docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixes #2198: Drop chunksizes when only when original_shape is different, not when it isn't found 328439361

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);