issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 327905732 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • jhamman · 3 ✖

issue 1

  • update minimum versions and associated code cleanup · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
403176563 https://github.com/pydata/xarray/pull/2204#issuecomment-403176563 https://api.github.com/repos/pydata/xarray/issues/2204 MDEyOklzc3VlQ29tbWVudDQwMzE3NjU2Mw== jhamman 2443309 2018-07-07T00:39:36Z 2018-07-07T00:39:36Z MEMBER

I managed to get the dask tests working here. This is ready to be merged.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update minimum versions and associated code cleanup 327905732
396772785 https://github.com/pydata/xarray/pull/2204#issuecomment-396772785 https://api.github.com/repos/pydata/xarray/issues/2204 MDEyOklzc3VlQ29tbWVudDM5Njc3Mjc4NQ== jhamman 2443309 2018-06-13T00:08:28Z 2018-06-13T00:08:28Z MEMBER

I'm lost on how to finish this up. Even bumping dask to 0.16 and distributed to 1.20, I can't seem to get the python 3.5 tests to pass. Does anyone have thoughts on how best to proceed here? We can skip the failing tests but in my opinion, that defeats the purpose of setting a minimum version. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update minimum versions and associated code cleanup 327905732
393960969 https://github.com/pydata/xarray/pull/2204#issuecomment-393960969 https://api.github.com/repos/pydata/xarray/issues/2204 MDEyOklzc3VlQ29tbWVudDM5Mzk2MDk2OQ== jhamman 2443309 2018-06-01T17:55:39Z 2018-06-01T17:55:39Z MEMBER

@shoyer - when you get a chance, it may be worth looking over the failing travis build. I've pinned dask to 0.16 in the py35 build and am getting a handful of failures, particularly with dask distributed. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update minimum versions and associated code cleanup 327905732

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);