issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 324105458 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • ENH: Plotting for groupby_bins · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
432145295 https://github.com/pydata/xarray/pull/2152#issuecomment-432145295 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDQzMjE0NTI5NQ== dcherian 2448579 2018-10-23T08:19:46Z 2018-10-23T08:19:46Z MEMBER

Failed test is cfgrib test.

Thanks @maahn 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458
428458765 https://github.com/pydata/xarray/pull/2152#issuecomment-428458765 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDQyODQ1ODc2NQ== dcherian 2448579 2018-10-10T06:54:07Z 2018-10-10T06:54:07Z MEMBER

Really sorry for the delay, @maahn.

I've merged master, refactored out the utility functions to utils.py, fixed the tests locally and added a whats-new entry. I'll merge once this round of tests pass.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458
393211218 https://github.com/pydata/xarray/pull/2152#issuecomment-393211218 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDM5MzIxMTIxOA== shoyer 1217238 2018-05-30T15:42:39Z 2018-05-30T15:42:39Z MEMBER

Rather than using interval_step_plot=True, what about making an entirely new plot method, plot.step()? That would feel a little cleaner to me.

I'm not sure that a step plot would be preferred by most users for a plot over an axis on which groupby_bins was applied. Personally, I would probably prefer a line + scatter plot (e.g., marker='s'). Maybe @rabernat (groupby_bins author) has opinions here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458
391413132 https://github.com/pydata/xarray/pull/2152#issuecomment-391413132 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDM5MTQxMzEzMg== shoyer 1217238 2018-05-23T16:31:07Z 2018-05-23T16:31:07Z MEMBER

A couple of other thoughts:

  1. For 2D plots that already show regions (imshow/pcolormesh), I'm not sure it makes sense to update the label to include the word "center". This plot around shows intervals pretty clearly:
  2. This needs tests, at least something to make sure that plotting with an Intervals on an axis does not crash in xarray/tests/test_plot.py
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458
389939666 https://github.com/pydata/xarray/pull/2152#issuecomment-389939666 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDM4OTkzOTY2Ng== rabernat 1197350 2018-05-17T17:07:21Z 2018-05-17T17:07:21Z MEMBER

This seems like a good idea.

groupby_bins has a labels option, which can override the default labels generated by pandas. That's what is done in the (multidimensional groupby example](http://xarray.pydata.org/en/stable/examples/multidimensional-coords.html#multidimensional-groupby).

I wonder if it's worth just making this behavior the default, or generating an additional coordinate for the bin centers automatically.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);