issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 299601789 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 3 ✖

issue 1

  • Tweak stickler config: ignore Python files in the docs & disable fixer · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
368343446 https://github.com/pydata/xarray/pull/1936#issuecomment-368343446 https://api.github.com/repos/pydata/xarray/issues/1936 MDEyOklzc3VlQ29tbWVudDM2ODM0MzQ0Ng== shoyer 1217238 2018-02-25T20:51:36Z 2018-02-25T20:51:36Z MEMBER

I also find it quite noisy and not very encouraging to submit PRs at an early "quick n dirty" stage, where you really shouldn't care about pep8...

I agree, but the alternative is to get a failed build error, and it can be a pain to dig through the Travis-CI to find out what went wrong. We use automated comments like this at work to enforce style, and on the whole I think they're probably a good thing.

I would certainly encourage contributors not to worry about these errors until they think their code is ready to submit.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweak stickler config: ignore Python files in the docs & disable fixer 299601789
368286733 https://github.com/pydata/xarray/pull/1936#issuecomment-368286733 https://api.github.com/repos/pydata/xarray/issues/1936 MDEyOklzc3VlQ29tbWVudDM2ODI4NjczMw== shoyer 1217238 2018-02-25T06:18:24Z 2018-02-25T06:18:24Z MEMBER

Maybe we should turn off the fixer also?

I'm not sure if you were suggesting turning it off entirely or only for the docs... but as I wrote above, I don't like it either.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweak stickler config: ignore Python files in the docs & disable fixer 299601789
368286655 https://github.com/pydata/xarray/pull/1936#issuecomment-368286655 https://api.github.com/repos/pydata/xarray/issues/1936 MDEyOklzc3VlQ29tbWVudDM2ODI4NjY1NQ== shoyer 1217238 2018-02-25T06:16:27Z 2018-02-25T06:16:27Z MEMBER

I would like to disable the fixer (which appears to use autopep8) entirely, for several reasons: 1. It enforces a very strict style automatically, e.g., removing spaces around arithmetic operators. This actually goes beyond PEP8, which suggests "Use your own judgment". I would rather have comments that I can tell a contributor to ignore and easily disable in the future (via the flake8 config). 2. The need to pull changes to a pull-request branch from GitHub is a surprising and somewhat disruptive. 3. I can't figure out how to disable the fixer from only some files.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweak stickler config: ignore Python files in the docs & disable fixer 299601789

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);