issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 298481284 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • shoyer · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
370174039 https://github.com/pydata/xarray/pull/1926#issuecomment-370174039 https://api.github.com/repos/pydata/xarray/issues/1926 MDEyOklzc3VlQ29tbWVudDM3MDE3NDAzOQ== shoyer 1217238 2018-03-03T19:39:30Z 2018-03-03T19:39:30Z MEMBER

@fmaussion any further concerns here? This looks good to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add x,y kwargs for plot.line(). 298481284
367414417 https://github.com/pydata/xarray/pull/1926#issuecomment-367414417 https://api.github.com/repos/pydata/xarray/issues/1926 MDEyOklzc3VlQ29tbWVudDM2NzQxNDQxNw== shoyer 1217238 2018-02-21T17:59:17Z 2018-02-21T17:59:17Z MEMBER

Yes, this is not valid syntax on Python 2.

On Wed, Feb 21, 2018 at 9:53 AM Deepak Cherian notifications@github.com wrote:

@dcherian commented on this pull request.

In xarray/plot/plot.py https://github.com/pydata/xarray/pull/1926#discussion_r169723308:

 add_legend = kwargs.pop('add_legend', True)

 ax = get_axis(figsize, size, aspect, ax)
  • error_msg = 'must be either None or one of %r' % list(darray.dims) +
  • if x not in [None, *darray.dims]:

I don't know what's wrong here. It runs locally; the tests pass and flake8 goes through plot.py without errors. Is it a python2 vs python3 thing?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1926#discussion_r169723308, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1pXVXGKhgmkR8yP3epLPvqZCXNipks5tXFgpgaJpZM4SLdeS . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add x,y kwargs for plot.line(). 298481284
367383795 https://github.com/pydata/xarray/pull/1926#issuecomment-367383795 https://api.github.com/repos/pydata/xarray/issues/1926 MDEyOklzc3VlQ29tbWVudDM2NzM4Mzc5NQ== shoyer 1217238 2018-02-21T16:26:26Z 2018-02-21T16:26:26Z MEMBER

My main thought is that this API would feel much more natural on a Dataset object, alongside a .plot.scatter() method.

That said, I suppose this could still be useful and I don't think it's harmful to expand the API here. It does feel a little strange that if you had a DataArray with non-dimension coordinates you could make a plot without including any of the DataArray values, e.g., xr.DataArray(..., dims=['x'], coords={'x': ..., 'y': ('x', ...)}, name='f').plot.line(x='x', y='y').

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add x,y kwargs for plot.line(). 298481284

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);