issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 298437967 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • isort · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
367778882 https://github.com/pydata/xarray/pull/1924#issuecomment-367778882 https://api.github.com/repos/pydata/xarray/issues/1924 MDEyOklzc3VlQ29tbWVudDM2Nzc3ODg4Mg== shoyer 1217238 2018-02-22T18:40:49Z 2018-02-22T18:40:49Z MEMBER

I would also be OK with just fixing this up in occasional cleanup PR.

If Stickler-CI supported this that might be a decisive consideration in terms of enforcing it. Certainly it's a better experience for contributors to get formatting errors as comments on a PR rather than a failed build.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   isort 298437967
367577212 https://github.com/pydata/xarray/pull/1924#issuecomment-367577212 https://api.github.com/repos/pydata/xarray/issues/1924 MDEyOklzc3VlQ29tbWVudDM2NzU3NzIxMg== shoyer 1217238 2018-02-22T06:05:54Z 2018-02-22T06:05:54Z MEMBER

Is it possible to enforce this programmatically, e.g., with flake8?

I'm a little surprised flake8 doesn't already require sorted imports by default. We use a modified version of pylint internally at Google that does this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   isort 298437967

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);