issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 296673404 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Coordinate attributes as DataArray type doesn't export to netcdf · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
368383671 https://github.com/pydata/xarray/issues/1906#issuecomment-368383671 https://api.github.com/repos/pydata/xarray/issues/1906 MDEyOklzc3VlQ29tbWVudDM2ODM4MzY3MQ== jhamman 2443309 2018-02-26T03:58:41Z 2018-02-26T03:58:41Z MEMBER

@mraspaud -

The way to do this with xarray is:

```Python arr = xr.DataArray([[1, 2, 3]], dims=['time', 'x']) arr['time'] = np.array([1]) time_bnds = xr.DataArray([[0, 1]], dims=('time', 'nv')) arr['time'].attrs['bounds'] = 'time_bnds'

dataset = xr.Dataset({'arr': arr, 'time_bnds': time_bnds})

dataset.info() ```

``` xarray.Dataset { dimensions: nv = 2 ; time = 1 ; x = 3 ;

variables: int64 time(time) ; time:bounds = time_bnds ; int64 arr(time, x) ; int64 time_bnds(time, nv) ;

// global attributes: } ```

Note this is the same number of lines of code and is CF compliant. I personally don't see us going down the path of nesting xarray objects inside of attrs.

Is there more to discuss here or should we close this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Coordinate attributes as DataArray type doesn't export to netcdf 296673404
365219456 https://github.com/pydata/xarray/issues/1906#issuecomment-365219456 https://api.github.com/repos/pydata/xarray/issues/1906 MDEyOklzc3VlQ29tbWVudDM2NTIxOTQ1Ng== fmaussion 10050469 2018-02-13T10:23:01Z 2018-02-13T10:23:01Z MEMBER

Also DataArrays can have attributes, so storing them as attributes could lead to quite intricate situations ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Coordinate attributes as DataArray type doesn't export to netcdf 296673404
365218953 https://github.com/pydata/xarray/issues/1906#issuecomment-365218953 https://api.github.com/repos/pydata/xarray/issues/1906 MDEyOklzc3VlQ29tbWVudDM2NTIxODk1Mw== fmaussion 10050469 2018-02-13T10:21:06Z 2018-02-13T10:21:06Z MEMBER

There are workarounds (like saving the time_bnds as a regular variable and putting its name as an attribute of the time variable)

This is not a workaround, this is what the CF conventions say to do: cell bounds need to be defined as variables, while the bounds attribute links to the name of this variable.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Coordinate attributes as DataArray type doesn't export to netcdf 296673404

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);