home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

6 rows where author_association = "MEMBER" and issue = 294735496 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

  • shoyer 2
  • fmaussion 2
  • jhamman 1
  • dcherian 1

issue 1

  • call to colorbar not thread safe · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
687271215 https://github.com/pydata/xarray/issues/1889#issuecomment-687271215 https://api.github.com/repos/pydata/xarray/issues/1889 MDEyOklzc3VlQ29tbWVudDY4NzI3MTIxNQ== dcherian 2448579 2020-09-04T17:02:03Z 2020-09-04T17:02:03Z MEMBER

Another way to do this would be to use da.map_blocks(plotfunc, template=...) with

``` python def plotfunc(da): f = plt.figure() ... f.close()

return da.time  # or similar

```

I have used this successfully with a distributed cluster.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  call to colorbar not thread safe 294735496
368384904 https://github.com/pydata/xarray/issues/1889#issuecomment-368384904 https://api.github.com/repos/pydata/xarray/issues/1889 MDEyOklzc3VlQ29tbWVudDM2ODM4NDkwNA== jhamman 2443309 2018-02-26T04:09:14Z 2018-02-26T04:09:14Z MEMBER

Closing for now. @apatlpo, feel free to reopen if there's more to discuss here.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  call to colorbar not thread safe 294735496
364518238 https://github.com/pydata/xarray/issues/1889#issuecomment-364518238 https://api.github.com/repos/pydata/xarray/issues/1889 MDEyOklzc3VlQ29tbWVudDM2NDUxODIzOA== shoyer 1217238 2018-02-09T18:31:28Z 2018-02-09T18:31:28Z MEMBER

@apatlpo sure, something like: ```python import threading import matplotlib.pyplot

MPL_LOCK = threading.Lock()

def save_imshow(data, path): with MPL_LOCK: fig, ax = plt.subplot() ax.imshow(data) fig.savefig(path) ``save_imshow()is now something you safely call in parallel (e.g., fromdask.array.map_blocks()`).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  call to colorbar not thread safe 294735496
363601313 https://github.com/pydata/xarray/issues/1889#issuecomment-363601313 https://api.github.com/repos/pydata/xarray/issues/1889 MDEyOklzc3VlQ29tbWVudDM2MzYwMTMxMw== shoyer 1217238 2018-02-06T23:26:49Z 2018-02-06T23:26:55Z MEMBER

I agree that it is certainly a best practice to avoid relying on global state from the pyplot module.

That said, my experience has been that even if you avoid using pyplot functions matplotlib is still not thread-safe (StackOverflow backs me up here). So you probably will need a thread-lock around your use of any plotting functions, anyways.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  call to colorbar not thread safe 294735496
363431406 https://github.com/pydata/xarray/issues/1889#issuecomment-363431406 https://api.github.com/repos/pydata/xarray/issues/1889 MDEyOklzc3VlQ29tbWVudDM2MzQzMTQwNg== fmaussion 10050469 2018-02-06T14:04:28Z 2018-02-06T14:04:28Z MEMBER

You are lucky, we just added a contributing guide to xarray: http://xarray.pydata.org/en/latest/contributing.html ;-)

The recommended way to install xarray (and any other local library btw) is:

pip install -e .

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  call to colorbar not thread safe 294735496
363416365 https://github.com/pydata/xarray/issues/1889#issuecomment-363416365 https://api.github.com/repos/pydata/xarray/issues/1889 MDEyOklzc3VlQ29tbWVudDM2MzQxNjM2NQ== fmaussion 10050469 2018-02-06T13:06:12Z 2018-02-06T13:06:12Z MEMBER

Thanks for the report! Would you like to open a PR? I think you are the best placed to see if you proposed fixes solve the problem for you

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  call to colorbar not thread safe 294735496

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 2401.233ms · About: xarray-datasette