issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 293445250 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • TypeError for NetCDF float16 output · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
368385281 https://github.com/pydata/xarray/issues/1877#issuecomment-368385281 https://api.github.com/repos/pydata/xarray/issues/1877 MDEyOklzc3VlQ29tbWVudDM2ODM4NTI4MQ== jhamman 2443309 2018-02-26T04:12:29Z 2018-02-26T04:12:29Z MEMBER

Do we have a verdict here? I'm personally fine raising an error (perhaps a better one than the current) unless an encoding/dtype is provided. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TypeError for NetCDF float16 output 293445250
362462223 https://github.com/pydata/xarray/issues/1877#issuecomment-362462223 https://api.github.com/repos/pydata/xarray/issues/1877 MDEyOklzc3VlQ29tbWVudDM2MjQ2MjIyMw== shoyer 1217238 2018-02-02T01:58:37Z 2018-02-02T01:58:37Z MEMBER

I suppose we could do while issuing a warning. Using encoding={'test': {'dtype': np.float32}} in to_netcdf() would be the way to silence the warning.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TypeError for NetCDF float16 output 293445250
362462091 https://github.com/pydata/xarray/issues/1877#issuecomment-362462091 https://api.github.com/repos/pydata/xarray/issues/1877 MDEyOklzc3VlQ29tbWVudDM2MjQ2MjA5MQ== shoyer 1217238 2018-02-02T01:57:47Z 2018-02-02T01:57:47Z MEMBER

It might be nice if the xarray netCDF engine promoted this to float32 instead.

I would generally lean against this type of behavior. Isn't it nice to know that float16 isn't supported rather than being surprised later when you discover your data was automatically upcast?

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TypeError for NetCDF float16 output 293445250

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);