issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 288466108 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Drop support for Python 2 · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
361906954 https://github.com/pydata/xarray/issues/1830#issuecomment-361906954 https://api.github.com/repos/pydata/xarray/issues/1830 MDEyOklzc3VlQ29tbWVudDM2MTkwNjk1NA== fmaussion 10050469 2018-01-31T11:38:16Z 2018-01-31T11:38:16Z MEMBER

I fully agree with the proposed changes!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 2 288466108
361825435 https://github.com/pydata/xarray/issues/1830#issuecomment-361825435 https://api.github.com/repos/pydata/xarray/issues/1830 MDEyOklzc3VlQ29tbWVudDM2MTgyNTQzNQ== jhamman 2443309 2018-01-31T05:08:22Z 2018-01-31T05:08:22Z MEMBER

Great. No argument there. I'll adjust the PR on the python3statement to reflect that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 2 288466108
361824307 https://github.com/pydata/xarray/issues/1830#issuecomment-361824307 https://api.github.com/repos/pydata/xarray/issues/1830 MDEyOklzc3VlQ29tbWVudDM2MTgyNDMwNw== shoyer 1217238 2018-01-31T04:59:55Z 2018-01-31T04:59:55Z MEMBER

I don't object to the timeline, but I don't think we're ready to commit to supporting Python 2 for all 0.X releases and stopping it with 1.0. The particular version number feels premature to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 2 288466108
361820059 https://github.com/pydata/xarray/issues/1830#issuecomment-361820059 https://api.github.com/repos/pydata/xarray/issues/1830 MDEyOklzc3VlQ29tbWVudDM2MTgyMDA1OQ== jhamman 2443309 2018-01-31T04:26:23Z 2018-01-31T04:26:23Z MEMBER

@pydata/xarray - any objections to the timeline here? We will need to close this before https://github.com/python3statement/python3statement.github.io/pull/102 can be merged.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 2 288466108
361808641 https://github.com/pydata/xarray/issues/1830#issuecomment-361808641 https://api.github.com/repos/pydata/xarray/issues/1830 MDEyOklzc3VlQ29tbWVudDM2MTgwODY0MQ== shoyer 1217238 2018-01-31T03:00:47Z 2018-01-31T03:00:47Z MEMBER

My inclination would be to save 1.0 until xarray's data model is stable, which probably means after https://github.com/pydata/xarray/issues/1603. If the timing works out for dropping Python 2 support that would be great, but I wouldn't want to force it.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 2 288466108
361786849 https://github.com/pydata/xarray/issues/1830#issuecomment-361786849 https://api.github.com/repos/pydata/xarray/issues/1830 MDEyOklzc3VlQ29tbWVudDM2MTc4Njg0OQ== jhamman 2443309 2018-01-31T00:56:09Z 2018-01-31T00:56:09Z MEMBER

I've just put up a PR on the python3statement repo. I've tentatively also listed 2019-01-01 as a possible target for Xarray 1.0, coincident with dropping Python2, but am now thinking we may need a larger discussion before that comes to any certainty. Anyhow, please take a look at https://github.com/python3statement/python3statement.github.io/pull/102.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 2 288466108
357770710 https://github.com/pydata/xarray/issues/1830#issuecomment-357770710 https://api.github.com/repos/pydata/xarray/issues/1830 MDEyOklzc3VlQ29tbWVudDM1Nzc3MDcxMA== shoyer 1217238 2018-01-15T19:33:09Z 2018-01-15T19:33:09Z MEMBER

My inclination would be to follow the lead of pandas here, since it's unlikely to make sense to update xarray without its dependencies. So I guess end of 2018 makes sense?

 
{
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 2 288466108

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);