issue_comments

Table actions

10 rows where author_association = "MEMBER" and issue = 288465429 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Drop support for Python 3.4 · 10 ✖

author_association 1

  • MEMBER · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
381365982 https://github.com/pydata/xarray/issues/1829#issuecomment-381365982 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM4MTM2NTk4Mg== shoyer 1217238 2018-04-14T22:45:33Z 2018-04-14T22:45:33Z MEMBER

Python 3.4 was supported by pandas 0.18, so I'm not sure what's going on here. I don't think it's really an xarray issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
378130526 https://github.com/pydata/xarray/issues/1829#issuecomment-378130526 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM3ODEzMDUyNg== jhamman 2443309 2018-04-03T05:14:03Z 2018-04-03T05:14:03Z MEMBER

Apologies for conflating the two issues here. I didn't mean to suggest we should skip straight to 0.11 for the sake of dropping 3.4. More that we should try to time the two together if possible. As @shoyer said, we can drop 3.4 from the test suite if need be.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
378124856 https://github.com/pydata/xarray/issues/1829#issuecomment-378124856 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM3ODEyNDg1Ng== shoyer 1217238 2018-04-03T04:29:20Z 2018-04-03T04:29:20Z MEMBER

Indeed, my plan is to release 0.10.3 shortly after your isin PR gets in :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
378123395 https://github.com/pydata/xarray/issues/1829#issuecomment-378123395 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM3ODEyMzM5NQ== max-sixty 5635139 2018-04-03T04:18:00Z 2018-04-03T04:18:00Z MEMBER

Completely agree re versions, and I can navigate around it; assuming 0.11 is not the next release

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
378120915 https://github.com/pydata/xarray/issues/1829#issuecomment-378120915 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM3ODEyMDkxNQ== shoyer 1217238 2018-04-03T03:58:30Z 2018-04-03T03:58:38Z MEMBER

If maintaining Python 3.4 support is a pain, I'm happy to drop it (certainly from our test suite). I would rather save major versions for major revisions to the project, however.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
378098280 https://github.com/pydata/xarray/issues/1829#issuecomment-378098280 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM3ODA5ODI4MA== jhamman 2443309 2018-04-03T01:25:16Z 2018-04-03T01:25:16Z MEMBER

Fine by me. Would we want to make the next version 0.11 then?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
378094859 https://github.com/pydata/xarray/issues/1829#issuecomment-378094859 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM3ODA5NDg1OQ== max-sixty 5635139 2018-04-03T01:03:02Z 2018-04-03T01:03:02Z MEMBER

@jhamman shall we do this now? Amazingly this is breaking the flake8 of https://github.com/pydata/xarray/pull/2031

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
361795137 https://github.com/pydata/xarray/issues/1829#issuecomment-361795137 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM2MTc5NTEzNw== jhamman 2443309 2018-01-31T01:40:38Z 2018-01-31T01:40:38Z MEMBER

Saving the PR until after 0.10 is released but here's commit that drops Python 3.4: 5c96b54929622d549ac059499bec4c32ddfee1ce

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
357814091 https://github.com/pydata/xarray/issues/1829#issuecomment-357814091 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM1NzgxNDA5MQ== shoyer 1217238 2018-01-15T23:46:26Z 2018-01-15T23:46:26Z MEMBER 
{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
357769101 https://github.com/pydata/xarray/issues/1829#issuecomment-357769101 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM1Nzc2OTEwMQ== shoyer 1217238 2018-01-15T19:24:58Z 2018-01-15T19:24:58Z MEMBER

It looks like pandas has already dropped Python 3.4 support in v0.21: https://github.com/pandas-dev/pandas/issues/18763

So I'd be favor of dropping it for xarray too in the next major release.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);