issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 283566613 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Support RGB[A] arrays in plot.imshow() · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
356811732 https://github.com/pydata/xarray/pull/1796#issuecomment-356811732 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1NjgxMTczMg== shoyer 1217238 2018-01-11T03:14:41Z 2018-01-11T03:14:41Z MEMBER

Thanks @Zac-HD !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
356519480 https://github.com/pydata/xarray/pull/1796#issuecomment-356519480 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1NjUxOTQ4MA== shoyer 1217238 2018-01-10T07:14:39Z 2018-01-10T07:14:39Z MEMBER

Should be fixed by https://github.com/pydata/xarray/pull/1814 which I just merged

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
356498589 https://github.com/pydata/xarray/pull/1796#issuecomment-356498589 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1NjQ5ODU4OQ== shoyer 1217238 2018-01-10T04:45:51Z 2018-01-10T04:45:51Z MEMBER

@Zac-HD Sounds good. At this point I don't think there are any blockers left for the 0.10.1 release (I wanted to get the pydap fix in, which we recently merged).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
356234506 https://github.com/pydata/xarray/pull/1796#issuecomment-356234506 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1NjIzNDUwNg== fmaussion 10050469 2018-01-09T09:51:17Z 2018-01-09T09:51:17Z MEMBER

Just restarted them, let's see how it goes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
355030478 https://github.com/pydata/xarray/pull/1796#issuecomment-355030478 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1NTAzMDQ3OA== fmaussion 10050469 2018-01-03T14:51:46Z 2018-01-03T14:51:46Z MEMBER

I'll add another todo (can be done in a separate PR if you don't have time ;-): modify the gallery example to plot the RGB image instead of the BW with our rasterio example here. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
353232290 https://github.com/pydata/xarray/pull/1796#issuecomment-353232290 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1MzIzMjI5MA== shoyer 1217238 2017-12-21T01:32:10Z 2017-12-21T01:32:10Z MEMBER

I should clarify: I don't think we should require the explicit name for the RGB dimension, but I think we should have an argument around so that's an option if desired. This is nice because it gives better error messages when things go wrong and makes it easier to write self-documented code. This would be consistent with the rest of our visualization functions, which provide an option for being fully explicit but don't require it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
353093545 https://github.com/pydata/xarray/pull/1796#issuecomment-353093545 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1MzA5MzU0NQ== shoyer 1217238 2017-12-20T15:27:39Z 2017-12-20T15:27:39Z MEMBER

I like this. My main concern is that I'd like a fully explicit way to opt into this behavior. Perhaps rgb='band' and/or rgba='band'?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);